Closed Bug 202393 Opened 17 years ago Closed 17 years ago

Add DOM class info for nsIXULTreeBuilder

Categories

(Core :: XUL, defect, P5)

x86
All
defect

Tracking

()

RESOLVED FIXED
mozilla1.5alpha

People

(Reporter: janv, Assigned: janv)

References

(Depends on 1 open bug)

Details

Attachments

(2 files)

So tree.builderView can be removed as well.
Blocks: 197463
Status: NEW → ASSIGNED
Priority: -- → P5
Target Milestone: --- → mozilla1.4beta
Attached patch patchSplinter Review
Attachment #120815 - Flags: superreview?(peterv)
Attachment #120815 - Flags: review?(axel)
Comment on attachment 120815 [details] [diff] [review]
patch

I would prefer to have the XUL stuff together in one place in
ns[I]DOMClassInfo.[h|cpp]
How about putting the TreeBuilder right next to its kin TreeContentView? And I
would prefer TreeBuilder over XULTreeBuilder, the XUL addition seems to be only
for CIs that exist in a non-XUL version, too.
But those are more style issues, jst or peterv should have a real word on this.

Other than that, r=axel@pike.org
Attachment #120815 - Flags: review?(axel) → review+
jst, peterv: I recall that new nsDOMClassInfoID records must be put at the end
or am I missing something ?
Yes, we try to keep nsDOMCI binary compatible, so new stuff needs to be added at
the end of that list.
Thanks, any chance to get this in for 1.4? (just asking)
I guess, this won't make 1.4
Target Milestone: mozilla1.4beta → mozilla1.5alpha
Attachment #120815 - Flags: superreview?(peterv) → superreview+
Depends on: 122846
checked in
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Attachment #127347 - Flags: superreview?(peterv)
Attachment #127347 - Flags: review?(varga)
Comment on attachment 127347 [details] [diff] [review]
Supplementary patch

yeah, I know
I just didn't want to check it in w/o testing
Attachment #127347 - Flags: superreview?(peterv)
Attachment #127347 - Flags: superreview?(jaggernaut)
Attachment #127347 - Flags: review?(varga)
Attachment #127347 - Flags: review+
Comment on attachment 127347 [details] [diff] [review]
Supplementary patch

sr=jag
Attachment #127347 - Flags: superreview?(jaggernaut) → superreview+
Comment on attachment 127347 [details] [diff] [review]
Supplementary patch

Checked in
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: shrir → xptoolkit.widgets
Depends on: 1508143
You need to log in before you can comment on or make changes to this bug.