202393 - Add DOM class info for nsIXULTreeBuilder

Status: RESOLVED FIXED

(Core :: XUL, defect, P5)

Description

[Jan Varga [:janv]]

So tree.builderView can be removed as well.

Comment 1

[Jan Varga [:janv]]

Attachment: patch

Comment 2

[Axel Hecht]

Comment on attachment 120815 [details] [diff] [review]
patch

I would prefer to have the XUL stuff together in one place in
ns[I]DOMClassInfo.[h|cpp]
How about putting the TreeBuilder right next to its kin TreeContentView? And I
would prefer TreeBuilder over XULTreeBuilder, the XUL addition seems to be only
for CIs that exist in a non-XUL version, too.
But those are more style issues, jst or peterv should have a real word on this.

Other than that, r=[e-mail]

Comment 3

[Jan Varga [:janv]]

jst, peterv: I recall that new nsDOMClassInfoID records must be put at the end
or am I missing something ?

Comment 4

[Peter Van der Beken [:peterv]]

Yes, we try to keep nsDOMCI binary compatible, so new stuff needs to be added at
the end of that list.

Comment 5

[Jan Varga [:janv]]

Thanks, any chance to get this in for 1.4? (just asking)

Comment 6

[Jan Varga [:janv]]

I guess, this won't make 1.4

Comment 7

[Jan Varga [:janv]]

checked in

Comment 8

[[e-mail]]

Attachment: Supplementary patch

Comment 9

[Jan Varga [:janv]]

Comment on attachment 127347 [details] [diff] [review]
Supplementary patch

yeah, I know
I just didn't want to check it in w/o testing

Comment 10

[jag (Peter Annema)]

Comment on attachment 127347 [details] [diff] [review]
Supplementary patch

sr=jag

Comment 11

[Jan Varga [:janv]]

Comment on attachment 127347 [details] [diff] [review]
Supplementary patch

Checked in