Closed Bug 2024160 Opened 6 months ago Closed 5 months ago

Allow moz-remote-image (SVG favicons) in the synced tabs sidebar

Categories

(Firefox :: Sidebar, defect)

Product:
Firefox
Component:
Sidebar
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
150 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- unaffected
firefox-esr140 --- unaffected
firefox148 --- unaffected
firefox149 + fixed
firefox150 --- fixed

People

(Reporter: tschuster, Assigned: tschuster)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Bug 2024160 - Allow moz-remote-image: (SVG favicons) in the synced tabs sidebar. r?#sync-reviewers,#sidebar-reviewers,Gijs
48 bytes, text/x-phabricator-request
Details | Review
Bug 2024160 - Allow moz-remote-image: (SVG favicons) in the synced tabs sidebar.
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-release+
Details | Review

Due to bug 2024094, I took the opportunity to look at our violation telemetry again and I noticed that we seem to be blocking moz-remote-image: URLs (used for SVG favicons) also in the "Tabs from other devices" sidebar.

See Also: → 2023389

[Tracking Requested - why for this release]: User visible regression with certain tabs in the sidebar missing favicons.

tracking-firefox149: --- → ?
Pushed by tschuster@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/10091a903af7 https://hg.mozilla.org/integration/autoland/rev/a4fe180dd494 Allow moz-remote-image: (SVG favicons) in the synced tabs sidebar. r=Gijs,sync-reviewers,skhamis

https://hg.mozilla.org/mozilla-central/rev/a4fe180dd494

Status: NEW → RESOLVED
Closed: 5 months ago
status-firefox150: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 150 Branch

Potential uplift in the planned dot release.

tracking-firefox149: ? → +

The patch landed in nightly and beta is affected.
:tschuster, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(tschuster)

firefox-release Uplift Approval Request

  • User impact if declined/Reason for urgency: Missing favicon for tabs in the Synced Tabs sidebar.
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: Just add allows something in the Content-Security-Policy.
  • String changes made/needed?: no
  • Is Android affected?: no
Attachment #9556674 - Flags: approval-mozilla-release?
Flags: needinfo?(tschuster)
QA Whiteboard: [qa-triage-done-c151/b150]
Attachment #9556674 - Flags: approval-mozilla-release? → approval-mozilla-release+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: