Closed Bug 2006015 Opened 9 months ago Closed 7 months ago

Enable browser.tabs.remoteSVGIconDecoding by default

Categories

(Firefox :: Tabbed Browser, task)

Product:
Firefox
Component:
Tabbed Browser
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
149 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- wontfix
firefox-esr140 --- wontfix
firefox147 --- wontfix
firefox148 --- wontfix
firefox149 --- fixed

People

(Reporter: tschuster, Assigned: tschuster)

References

Details

(Keywords: sec-want, Whiteboard: [adv-main149-])

Crash Data

Attachments

(2 files)

(secure)
48 bytes, text/x-phabricator-request
Details | Review
(secure)
48 bytes, text/x-phabricator-request
Details | Review

I think before enabling remote SVG rendering by default we should first at least get the color-scheme handling working (bug 2004736).

Summary: browser.tabs.remoteSVGIconDecoding by default → Enable browser.tabs.remoteSVGIconDecoding by default
Keywords: sec-want
Depends on: 2006037
Depends on: 2008986
Attached file (secure) —
Attached file (secure) —
Pushed by tschuster@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e2d3c7f50a97 https://hg.mozilla.org/integration/autoland/rev/eed7988697d4 Enable browser.tabs.remoteSVGIconDecoding by default. r=tabbrowser-reviewers,dao

https://hg.mozilla.org/mozilla-central/rev/eed7988697d4

Group: firefox-core-security → core-security-release
Status: NEW → RESOLVED
Closed: 7 months ago
status-firefox147: --- → wontfix
status-firefox148: --- → wontfix
status-firefox149: --- → fixed
status-firefox-esr115: --- → wontfix
status-firefox-esr140: --- → wontfix
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/131497bb1b74 https://hg.mozilla.org/mozilla-central/rev/36e30118c116 Revert "Bug 2006015 - Enable browser.tabs.remoteSVGIconDecoding by default. r=tabbrowser-reviewers,dao" for causing content crashes.
Status: RESOLVED → REOPENED
status-firefox149: fixed → ---
Resolution: FIXED → ---
Target Milestone: 149 Branch → ---

E.g. bp-1e0f428e-c77f-4396-a5cf-a91430260120 as crash report.

Crash Signature: [@ IPCError-browser | RecvGetPageIconStream Wrong process type]
Flags: needinfo?(tschuster)

Ah, I believe the crash is actually not caused by the tab favicons, but instead caused by the favicons in the sync menu. Seems like we use page-icon: for those, sometimes or always, in certain circumstances? I will just split the sync favicon stuff out of this and only enable remote tab favicons.

Flags: needinfo?(tschuster)
Pushed by tschuster@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/5a6850032a86 https://hg.mozilla.org/integration/autoland/rev/4725516b7fc8 Enable browser.tabs.remoteSVGIconDecoding by default. r=tabbrowser-reviewers,dao
See Also: → 2011412

https://hg.mozilla.org/mozilla-central/rev/f2b5af495a99

Status: REOPENED → RESOLVED
Closed: 7 months ago → 7 months ago
status-firefox149: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
QA Whiteboard: [sec] [qa-triage-done-c150/b149]
Regressions: 2023389
Whiteboard: [adv-main149-]
Regressions: 2024094
Regressions: 2024160
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: