2024674 - Remove SearchService shims introduced in bug 2000685

Status: RESOLVED FIXED

(Firefox :: New Tab Page, task)

Description

[Mike Conley (:mconley) (:⚙️)]

Once 149 makes it to the release channel OR we've decided we're no longer shipping train-hops to 148 (which I think is now), we can remove the shims introduced in bug 2000685.

They're here:

• https://searchfox.org/firefox-main/rev/fa20ce29b1a82b717b7ff6863af8c12b381b3ec5/browser/extensions/newtab/lib/PlacesFeed.sys.mjs#301-308
• https://searchfox.org/firefox-main/rev/fa20ce29b1a82b717b7ff6863af8c12b381b3ec5/browser/extensions/newtab/lib/PlacesFeed.sys.mjs#312-317
• https://searchfox.org/firefox-main/rev/fa20ce29b1a82b717b7ff6863af8c12b381b3ec5/browser/extensions/newtab/lib/TopSitesFeed.sys.mjs#173-178
• https://searchfox.org/firefox-main/rev/fa20ce29b1a82b717b7ff6863af8c12b381b3ec5/browser/extensions/newtab/lib/TopSitesFeed.sys.mjs#1531-1536
• https://searchfox.org/firefox-main/rev/fa20ce29b1a82b717b7ff6863af8c12b381b3ec5/browser/extensions/newtab/lib/TopSitesFeed.sys.mjs#1988-1990
• https://searchfox.org/firefox-main/rev/fa20ce29b1a82b717b7ff6863af8c12b381b3ec5/browser/extensions/newtab/test/browser/browser_topsites_section.js#3-17
• This can probably be removed now: https://searchfox.org/firefox-main/rev/fa20ce29b1a82b717b7ff6863af8c12b381b3ec5/browser/extensions/newtab/test/unit/unit-entry.js#454-473

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 2024674 - Remove SearchService newtab train-hop shims introduced in bug 2000685 now that Firefox 149 has shipped. r?#home-newtab-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c1feb0c7bf52
https://hg.mozilla.org/integration/autoland/rev/380c9b95f3fc
Remove SearchService newtab train-hop shims introduced in bug 2000685 now that Firefox 149 has shipped. r=home-newtab-reviewers,maxx

Comment 3

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/380c9b95f3fc