2000685 - Replace the search service instance with a singleton

Status: RESOLVED FIXED

(Firefox :: Search, task, P1)

Description

[Mark Banner (:standard8)]

Working towards bug 1643008, one step is to replace the current XPCOM service for Search with a singleton instance. We can follow up with removing the idl interfaces later.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 2000685 - Replace the search service instance with a singleton - initial mechanical changes. r?mcheang!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 2000685 - Replace Services.search with direct loading of the SearchService singleton in toolkit search code. r?mcheang!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 2000685 - Replace Services.search with direct loading of the SearchService singleton in enterprise policies code. r?mcheang!

Comment 4

[Mark Banner (:standard8)]

Attachment: Bug 2000685 - Replace Services.search with direct loading of the SearchService singleton in extensions code. r?mcheang!

Comment 5

[Mark Banner (:standard8)]

Attachment: Bug 2000685 - Replace Services.search with direct loading of the SearchService singleton in newtab code. r?mcheang!

Comment 6

[Mark Banner (:standard8)]

Attachment: Bug 2000685 - Replace Services.search with direct loading of the SearchService singleton in urlbar and search code. r?mcheang!

Comment 7

[Mark Banner (:standard8)]

Attachment: Bug 2000685 - Replace Services.search with direct loading of the SearchService singleton in other code. r?mcheang!

Comment 8

[Mark Banner (:standard8)]

Attachment: Bug 2000685 - Fix various tests after moving SearchService to be a singleton. r?mcheang!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eea6e5a1191e
https://hg.mozilla.org/integration/autoland/rev/e4e226d88ea9
Replace the search service instance with a singleton - initial mechanical changes. r=mcheang,frontend-codestyle-reviewers
https://github.com/mozilla-firefox/firefox/commit/66fe0f41231d
https://hg.mozilla.org/integration/autoland/rev/af0c0fba3e70
Replace Services.search with direct loading of the SearchService singleton in toolkit search code. r=mcheang
https://github.com/mozilla-firefox/firefox/commit/7d7bbd910f31
https://hg.mozilla.org/integration/autoland/rev/943282495caf
Replace Services.search with direct loading of the SearchService singleton in enterprise policies code. r=mcheang
https://github.com/mozilla-firefox/firefox/commit/462b01b86a64
https://hg.mozilla.org/integration/autoland/rev/e6502dbe3d73
Replace Services.search with direct loading of the SearchService singleton in extensions code. r=mcheang,extension-reviewers,robwu
https://github.com/mozilla-firefox/firefox/commit/25f775d4a22c
https://hg.mozilla.org/integration/autoland/rev/6727f6d01013
Replace Services.search with direct loading of the SearchService singleton in newtab code. r=mcheang,home-newtab-reviewers,nbarrett
https://github.com/mozilla-firefox/firefox/commit/b0f3b3e97529
https://hg.mozilla.org/integration/autoland/rev/a4252954cc4c
Replace Services.search with direct loading of the SearchService singleton in urlbar and search code. r=mcheang
https://github.com/mozilla-firefox/firefox/commit/94811f67089f
https://hg.mozilla.org/integration/autoland/rev/ae47cc58d4af
Replace Services.search with direct loading of the SearchService singleton in other code. r=mcheang,extension-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,ai-frontend-reviewers,toolkit-telemetry-reviewers,hsohaney,emcminn,robwu,Gijs
https://github.com/mozilla-firefox/firefox/commit/844b03e2a85d
https://hg.mozilla.org/integration/autoland/rev/247c1708e9d2
Fix various tests after moving SearchService to be a singleton. r=mcheang,toolkit-telemetry-reviewers,mstriemer

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/105a7d335158
https://hg.mozilla.org/integration/autoland/rev/fa3e97400dc4
Revert "Bug 2000685 - Fix various tests after moving SearchService to be a singleton. r=mcheang,toolkit-telemetry-reviewers,mstriemer" for causing newtab failure. DONTBUILD

Comment 11

[Cristina Horotan [:chorotan]]

Backed out for causing newtab failure

Backout link

Push with failures

Failure log

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/69ffce06bf40
https://hg.mozilla.org/integration/autoland/rev/af8c6644816b
Replace the search service instance with a singleton - initial mechanical changes. r=mcheang,frontend-codestyle-reviewers
https://github.com/mozilla-firefox/firefox/commit/b4fe1e4f474b
https://hg.mozilla.org/integration/autoland/rev/33e2f829b9af
Replace Services.search with direct loading of the SearchService singleton in toolkit search code. r=mcheang
https://github.com/mozilla-firefox/firefox/commit/ddd0d8c93fb4
https://hg.mozilla.org/integration/autoland/rev/8d5d2e3de8ce
Replace Services.search with direct loading of the SearchService singleton in enterprise policies code. r=mcheang
https://github.com/mozilla-firefox/firefox/commit/0ee3529e7ae7
https://hg.mozilla.org/integration/autoland/rev/1ef719107776
Replace Services.search with direct loading of the SearchService singleton in extensions code. r=mcheang,extension-reviewers,robwu
https://github.com/mozilla-firefox/firefox/commit/f2e8be6cf71d
https://hg.mozilla.org/integration/autoland/rev/94bbfb9990e9
Replace Services.search with direct loading of the SearchService singleton in newtab code. r=mcheang,home-newtab-reviewers,nbarrett
https://github.com/mozilla-firefox/firefox/commit/e9fab38dd9cf
https://hg.mozilla.org/integration/autoland/rev/21458ac28dec
Replace Services.search with direct loading of the SearchService singleton in urlbar and search code. r=mcheang
https://github.com/mozilla-firefox/firefox/commit/3667d27bf287
https://hg.mozilla.org/integration/autoland/rev/01d9f1af998c
Replace Services.search with direct loading of the SearchService singleton in other code. r=mcheang,extension-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,ai-frontend-reviewers,toolkit-telemetry-reviewers,hsohaney,emcminn,robwu,Gijs
https://github.com/mozilla-firefox/firefox/commit/2296e51ed521
https://hg.mozilla.org/integration/autoland/rev/f469d3f1ecb8
Fix various tests after moving SearchService to be a singleton. r=mcheang,toolkit-telemetry-reviewers,mstriemer

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/af8c6644816b
https://hg.mozilla.org/mozilla-central/rev/33e2f829b9af
https://hg.mozilla.org/mozilla-central/rev/8d5d2e3de8ce
https://hg.mozilla.org/mozilla-central/rev/1ef719107776
https://hg.mozilla.org/mozilla-central/rev/94bbfb9990e9
https://hg.mozilla.org/mozilla-central/rev/21458ac28dec
https://hg.mozilla.org/mozilla-central/rev/01d9f1af998c
https://hg.mozilla.org/mozilla-central/rev/f469d3f1ecb8