2024744 - Assertion failure "animation->GetTimeline()->IsMonotonicallyIncreasing()" when setting timeline from the finite timeline to document timeline

Status: RESOLVED FIXED

(Core :: CSS Transitions and Animations, defect)

Description

[Boris Chiou [:boris]]

We may hit this assertion:

Assertion failure: animation->GetTimeline() && !animation->GetTimeline()->IsMonotonicallyIncreasing(),

When setting the timeline of a pending paused animation from scroll timeline to document timeline. This happens because we forgot to remove this animation from the tracker (since it is not pending anymore).

Comment 1

[Boris Chiou [:boris]]

Attachment: Bug 2024744 - Remove the animation from the pending animation tracker when we cancel the pending task.

This is necessary for scroll/view timeline animations because we have to
make sure they are not in the tracker when we try to trigger the pending
set.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1c2cc4a1d943
https://hg.mozilla.org/integration/autoland/rev/38fb39c7601b
Remove the animation from the pending animation tracker when we cancel the pending task. r=firefox-style-system-reviewers,layout-scroll-driven-animation-reviewers,dshin

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/38fb39c7601b

Comment 4

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/38fb39c7601b