2025884 - Introduce Send Tab toolbar button

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P2)

Description

[Robin Steuber (she/her) [:bytesized]]

Provide a visible, easily accessible entry point for Send Tab directly in the browser toolbar, improving overall feature visibility (not added to the toolbar by default).

Comment 1

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 2025884 - Add Send Tab toolbar button r=skhamis!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c94b0bc61571
https://hg.mozilla.org/integration/autoland/rev/42c1adc78a7e
Add Send Tab toolbar button r=skhamis,fluent-reviewers,desktop-theme-reviewers,sync-reviewers,bolsson,sfoster

Comment 3

[pstanciu]

Backed out for causing bc failures @ browser_contextmenu_sendpage.js

• https://hg.mozilla.org/integration/autoland/rev/320607af54ab0bc2c8464ff3cbe69432a2bf5e51
• Push with failures
• Failure Log browser_contextmenu_sendpage.js
• Push with failures browser_contextmenu.js
• Failure Log browser_contextmenu.js

Comment 4

[Robin Steuber (she/her) [:bytesized]]

Working on it

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b0fe25b075d6
https://hg.mozilla.org/integration/autoland/rev/22cd8d2cfa54
Add Send Tab toolbar button r=skhamis,fluent-reviewers,desktop-theme-reviewers,sync-reviewers,bolsson,sfoster

Comment 6

[pstanciu]

Backed out for causing bc failures @browser_contextmenu.js

• https://hg.mozilla.org/integration/autoland/rev/f396b9e62055c54c59de26a8d61d7d2e7525c0d4
• Push with failures
• Failure Log

Comment 7

[BMO Github Automation]

Authored by https://github.com/bytesized
https://github.com/mozilla/enterprise-firefox/commit/c94b0bc61571dcc280d1ee52b5646941fe6d09ac
[enterprise-main] Bug 2025884 - Add Send Tab toolbar button r=skhamis,fluent-reviewers,desktop-theme-reviewers,sync-reviewers,bolsson,sfoster

Authored by https://github.com/bytesized
https://github.com/mozilla/enterprise-firefox/commit/b0fe25b075d6c52ef185f410ce230f0703f52562
[enterprise-main] Bug 2025884 - Add Send Tab toolbar button r=skhamis,fluent-reviewers,desktop-theme-reviewers,sync-reviewers,bolsson,sfoster

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0b7f80ad5659
https://hg.mozilla.org/integration/autoland/rev/974bb45e87fb
Add Send Tab toolbar button r=skhamis,fluent-reviewers,desktop-theme-reviewers,sync-reviewers,bolsson,sfoster

Comment 9

[agoloman]

Backed out for causing multiple failures.

• Backout link
• Push with failures
• Failure Log
• Failure Log
• Failure Log

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/054fa5a0a884
https://hg.mozilla.org/integration/autoland/rev/4ef3ca7bf5ec
Add Send Tab toolbar button r=skhamis,fluent-reviewers,desktop-theme-reviewers,sync-reviewers,bolsson,sfoster

Comment 11

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures @ browser_sendtab_toolbarbutton.js

Backout link

Push with failures

Failure log
Failure log 2

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f26bc11ccac9
https://hg.mozilla.org/integration/autoland/rev/7c878292d857
Add Send Tab toolbar button r=skhamis,fluent-reviewers,desktop-theme-reviewers,sync-reviewers,bolsson,sfoster

Comment 13

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/7c878292d857

Comment 14

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 2025884 - Add Send Tab toolbar button

Original Revision: https://phabricator.services.mozilla.com/D291602

Comment 15

[Francesco Lodolo [:flod]]

This is introducing a new string that isn't even exposed for localization yet. Given 151 moves to RC in 4 days, this is not something that we should uplift.

Comment 16

[Donal Meehan [:dmeehan]]

This is not suitable for uplift given Fx151 goes to release next week, see https://bugzilla.mozilla.org/show_bug.cgi?id=2031472#c25

Comment 17

[Ryan VanderMeulen [:RyanVM]]

Please add a relnote-firefox? nomination to this bug when you get a chance.

Comment 18

[Robin Steuber (she/her) [:bytesized]]

Release Note Request
[Why is this notable]: New toolbar button that is not in the toolbar by default. Users might want to know about it.
[Affects Firefox for Android]: No
[Suggested wording]: A "Send tab" toolbar button is now available which can be added via More Tools->Customize Toolbar.
[Links (documentation, blog post, etc)]: There is currently no documentation for this.

Comment 19

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx152 relnotes.