2031472 - Implement flows for signed-out and single-device users in context menus

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P2)

Description

[Robin Steuber (she/her) [:bytesized]]

From Jira:

Work is complete when the following is true:

• “send to mobile” is visible when the user is signed out, signed in with sync disabled, or only has a single device connected
• Signed out users
  • opens a new tab to a sign-in/sign-up page with tracking data when “send to mobile” is clicked
  • call promiseConnectAccountURI() (example usage) with “send-tab-link-context-menu” as the entry point to open a new tab with the sign-in page
• Signed in users with sync disabled
  • reveals a submenu item with an “Enable sync to send a tab” item which opens about:settings#sync when “send to mobile” is clicked
• Single-device users
  • displays two menu items divided by a separator when “send to mobile” is clicked as below
    • Connect your phone
    • Menu Separator
    • Don’t see your device?
  • when “Connect your phone” is clicked call promisePairingURI() (example usage) with “send-tab-link-context-menu” as the entry point to open a new tab with pairing instructions
  • when “Don’t see your device?” is clicked a new tab is opened with a localized SUMO article of Send Tab from Firefox desktop to other devices | Firefox Help.

Comment 1

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 2031472 - Implement flows for signed-out and single-device users in context menus r=LougeniaBailey!,skhamis!

Comment 2

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 2031472 - Remove FTL that does not appear to be used r=LougeniaBailey!,skhamis!

Comment 3

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 2031472 - Test fixes for Bug 2031472 and 2025884 patches r=skhamis!

Comment 4

[David Durst [:ddurst]]

Ready to go (this is me testing linkage, disregard).

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/819ed93e12ec
https://hg.mozilla.org/integration/autoland/rev/8fa1a454bed9
Implement flows for signed-out and single-device users in context menus r=skhamis,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/8d7420163b56
https://hg.mozilla.org/integration/autoland/rev/c2fadd321bab
Remove FTL that does not appear to be used r=LougeniaBailey,skhamis,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/a0dae9a6117c
https://hg.mozilla.org/integration/autoland/rev/14ac7fea9aef
Test fixes for Bug 2031472 and 2025884 patches r=skhamis

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7699f5484de2
https://hg.mozilla.org/integration/autoland/rev/320607af54ab
Revert "Bug 2031472, Bug 2025884 - Test fixes for Bug 2031472 and 2025884 patches r=skhamis" for causing bc failures @ browser_contextmenu_sendpage.js

Comment 7

[pstanciu]

Backed out for causing bc failures @ browser_contextmenu_sendpage.js

• https://hg.mozilla.org/integration/autoland/rev/320607af54ab0bc2c8464ff3cbe69432a2bf5e51
• Push with failures
• Failure Log browser_contextmenu_sendpage.js
• Push with failures browser_contextmenu.js
• Failure Log browser_contextmenu.js

Comment 8

[Robin Steuber (she/her) [:bytesized]]

Working on it

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3b9538dc1b66
https://hg.mozilla.org/integration/autoland/rev/0fc88d577384
Implement flows for signed-out and single-device users in context menus r=skhamis,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/b488a76c97c3
https://hg.mozilla.org/integration/autoland/rev/3438a8cd2347
Remove FTL that does not appear to be used r=LougeniaBailey,skhamis,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/9b5e75bd9d60
https://hg.mozilla.org/integration/autoland/rev/ff4f901ad489
Test fixes for Bug 2031472 and 2025884 patches r=skhamis

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/769bf6779362
https://hg.mozilla.org/integration/autoland/rev/f396b9e62055
Revert "Bug 2031472, Bug 2025884 - Test fixes for Bug 2031472 and 2025884 patches r=skhamis" for causing bc failures @browser_contextmenu.js

Comment 11

[pstanciu]

Backed out for causing bc failures @browser_contextmenu.js

• https://hg.mozilla.org/integration/autoland/rev/f396b9e62055c54c59de26a8d61d7d2e7525c0d4
• Push with failures
• Failure Log

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/2aadb0edbfca
https://hg.mozilla.org/integration/autoland/rev/8854c9c76525
Implement flows for signed-out and single-device users in context menus r=skhamis,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/2b34d1fc6f73
https://hg.mozilla.org/integration/autoland/rev/06ec4e6c2763
Remove FTL that does not appear to be used r=LougeniaBailey,skhamis,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/0ca10d282d0c
https://hg.mozilla.org/integration/autoland/rev/952727a1a1b5
Test fixes for Bug 2031472 and 2025884 patches r=skhamis

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8cf691a33815
https://hg.mozilla.org/integration/autoland/rev/3fc566e9afad
Revert "Bug 2031472, Bug 2025884 - Test fixes for Bug 2031472 and 2025884 patches r=skhamis" for causing multiple failures.

Comment 14

[agoloman]

Backed out for causing multiple failures.

• Backout link
• Push with failures
• Failure Log
• Failure Log
• Failure Log

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/871a2dbf6328
https://hg.mozilla.org/integration/autoland/rev/db73faa5011d
Implement flows for signed-out and single-device users in context menus r=skhamis,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/81cc077a71af
https://hg.mozilla.org/integration/autoland/rev/60871c47fabf
Remove FTL that does not appear to be used r=LougeniaBailey,skhamis,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/05801556b66d
https://hg.mozilla.org/integration/autoland/rev/531f3cccb0ce
Test fixes for Bug 2031472 and 2025884 patches r=skhamis

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9476cf75b716
https://hg.mozilla.org/integration/autoland/rev/3710e892567f
Revert "Bug 2031472, Bug 2025884 - Test fixes for Bug 2031472 and 2025884 patches r=skhamis" for causing bc failures @ browser_sendtab_toolbarbutton.js

Comment 17

[Norisz Fay [:noriszfay]]

Backed out for causing bc failures @ browser_sendtab_toolbarbutton.js

Backout link

Push with failures

Failure log
Failure log 2

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/31e719ff9c8a
https://hg.mozilla.org/integration/autoland/rev/b6d5ef39ce52
Implement flows for signed-out and single-device users in context menus r=skhamis,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/3b1c53dbad87
https://hg.mozilla.org/integration/autoland/rev/fd215fd62c4a
Remove FTL that does not appear to be used r=LougeniaBailey,skhamis,fluent-reviewers,bolsson
https://github.com/mozilla-firefox/firefox/commit/9bdba40da8b5
https://hg.mozilla.org/integration/autoland/rev/9757e2d0258a
Test fixes for Bug 2031472 and 2025884 patches r=skhamis

Comment 19

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/b6d5ef39ce52
https://hg.mozilla.org/mozilla-central/rev/fd215fd62c4a
https://hg.mozilla.org/mozilla-central/rev/9757e2d0258a

Comment 20

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 2031472 - Implement flows for signed-out and single-device users in context menus

Original Revision: https://phabricator.services.mozilla.com/D294847

Comment 21

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 2031472 - Remove FTL that does not appear to be used

Original Revision: https://phabricator.services.mozilla.com/D295722

Comment 22

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Product says target for this feature is 151.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Add "Send tab" button to toolbar (it looks like a phone with an arrow on the right side pointing to it). Navigate to an online page such as wikipedia. Click toolbar button. Check that "Sign in to send tabs" takes you to a sign in page at https://accounts.firefox.com.

Sign in to a Firefox account. Ensure that no other devices are connected to the account. Click the toolbar button. Check that that "Connect phone" takes you to a URL beginning with https://accounts.firefox.com/pair. Check that "Don't see your device?" takes you to the localized version of https://support.mozilla.org/en-US/kb/send-tab-firefox-desktop-other-devices?redirectslug=send-tab-firefox-desktop-mobile&redirectlocale=en-US#w_i-dont-see-my-device-listed.

Disable sync by clicking "Manage Sync", then "Disconnect". Click the toolbar icon. Check that clicking “Enable sync to send a tab” opens a new tab to about:settings#sync.

Re-enable sync by going to about:settings#sync and clicking "Turn on syncing". Go to about:profiles and make a new profile. Sign in to Firefox with the same account used before. Navigate to an online page such as wikipedia. Click the toolbar icon. Send the tab to the first profile. Click on the notification to accept the tab being sent. Check that the tab is opened in the first profile.

All checks above should be repeated for these menus:

• Right click on the background of the page and go to "Send to Mobile"/"Send to Device".
• Right click on a link in the page and go to "Send Link to Mobile"/"Send link to Device".
• Right click on a tab and go to "Send to Mobile"/"Send to Device".
• Risk associated with taking this patch: medium
• Explanation of risk level: Two small features are basically being added here. But testing suggests that they work and it seems unlikely that they fail in a way that affects anything other than the new functionality.
• String changes made/needed?: Yes. D294847 contains a fluent migration of 3 strings and the addition of main-context-menu-send-to-mobile-sign-in. D295722 removes strings that are no longer needed.
• Is Android affected?: no

Comment 23

[Robin Steuber (she/her) [:bytesized]]

Attachment: Bug 2031472 - Test fixes for Bug 2031472 and 2025884 patches

Original Revision: https://phabricator.services.mozilla.com/D296483

Comment 24

[Francesco Lodolo [:flod]]

(In reply to Phabricator Automation from comment #22)

• String changes made/needed?: Yes. D294847 contains a fluent migration of 3 strings and the addition of main-context-menu-send-to-mobile-sign-in. D295722 removes strings that are no longer needed.

The patch introduces 4 strings though, so 1 will remain untranslated. Similar to bug 2025884, this doesn't feel like something we should uplift to beta when we're only 4 days away from RC cut-off.

Comment 25

[Donal Meehan [:dmeehan]]

:bytesized, this is medium risk, and as mentioned in Comment 24 it also contains strings.
This is not suitable for uplift, but adding a need-info before rejecting in case there is some context missing?
I see it mentioned that Product wants to target 151, but this is not suitable given the risk and strings.

Comment 26

[Robin Steuber (she/her) [:bytesized]]

Thanks for letting me know.