2025906 - Clicking HNT background no longer blurs focus from HNT's search box

Status: VERIFIED FIXED

(Firefox :: Search, defect, P2)

Description

[Chris Peterson [:cpeterson]]

Attachment: screenshot.png

@ Moritz: this bug is a regression from your fix for bug 1986130. I bisected this regression to this pushlog:

https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=d0cf9c9b38029c1e47fa53c0f0658deda7c4aa12&tochange=86750f9c64a2cbefc415abce2adf2bce553bd135

Steps to reproduce

1. Open the HNT.
2. Click in the HNT's search box to focus it.
3. Click the HNT page's background to blur focus from the search box.

Expected result

The HNT's search box should no longer have focus.

Actual result

The HNT's search box still has focus.

If you click focus to the address bar or another tab, the focus is removed from the HNT's search box.

Comment 2

[Moritz Beier [:mbeier]]

Attachment: Bug 2025906 - Clicking HNT background no longer removes fake focus from HNT's search box. r=home-newtab-reviewers,urlbar-reviewers,mconley,jteow

Before bug 1986130, urlbar.addEventListener relayed the call to the input element. Now, urlbar is the container element itself, so it has its own addEventListener and other code needs to explicitly add listeners on the input field.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/736a25ba7a9c
https://hg.mozilla.org/integration/autoland/rev/6e672d7c2c37
Clicking HNT background no longer removes fake focus from HNT's search box. r=home-newtab-reviewers,urlbar-reviewers,mconley,jteow

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d4943979e62a
https://hg.mozilla.org/integration/autoland/rev/07b40dfc11ad
Revert "Bug 2025906 - Clicking HNT background no longer removes fake focus from HNT's search box. r=home-newtab-reviewers,urlbar-reviewers,mconley,jteow" for causing bc failures at browser_suppressFocusBorder.js

Comment 5

[rperta]

Backed out for causing bc failures at browser_suppressFocusBorder.js
Backout link
Push with failures
Failure log(s)

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/25cc04d903e2
https://hg.mozilla.org/integration/autoland/rev/392adaff4a12
Clicking HNT background no longer removes fake focus from HNT's search box. r=home-newtab-reviewers,urlbar-reviewers,mconley,jteow

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/938d3a7c0430
https://hg.mozilla.org/integration/autoland/rev/9c8c6e8ae209
Revert "Bug 2025906 - Clicking HNT background no longer removes fake focus from HNT's search box. r=home-newtab-reviewers,urlbar-reviewers,mconley,jteow" for causing bc failures @browser_suppressFocusBorder.js.

Comment 8

[agoloman]

Backed out for causing bc failures @browser_suppressFocusBorder.js.

• Backout link
• Push with failures
• Failure Log

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4da8080cd684
https://hg.mozilla.org/integration/autoland/rev/e51ac39cbffe
Clicking HNT background no longer removes fake focus from HNT's search box. r=home-newtab-reviewers,urlbar-reviewers,mconley,jteow

Comment 10

[rperta]

https://hg.mozilla.org/mozilla-central/rev/e51ac39cbffe

Comment 11

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:mbeier, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.

Comment 12

[Ina Popescu, Desktop QA]

I've reproduced the issue in Firefox Nightly 151.0a1 (2026-03-24) on macOS 15. The issue no longer reproduces in the latest Nightly 151.0a1 on macOS 15, Windows 10 and Ubuntu 22.04. Marking as Verified Fixed.