Closed Bug 2026173 Opened 5 months ago Closed 4 months ago

The Memories button state is not remembered when switching tabs

Categories

(Core :: Machine Learning: Frontend, defect)

Desktop
Unspecified
defect

Tracking

()

VERIFIED FIXED
151 Branch
Tracking Status
firefox-esr140 --- disabled
firefox149 --- disabled
firefox150 --- wontfix
firefox151 --- verified

People

(Reporter: rdoghi, Assigned: ngrato)

References

Details

(Whiteboard: [genai][chat])

Attachments

(3 files)

Attached video crossed.mp4

Found in

  • 151.0a1 (2026-03-25)

Affected versions

  • 151.0a1 (2026-03-25)

Affected platforms

  • all

Steps to reproduce

  1. Open a Smart Window.
  2. Have 2 tabs with websites opened.
  3. Open the Ask sidebar for one of the tabs and Disable the Memories from the Memories button.
  4. Switch between tabs.

Expected result

  • The Tab where the Memories were crossed off should still be crossed off when the user returns to that tab.

Actual result

  • The Memories are turned on each time a user opens or comes back to the tab.

Regression range
N/A

Memory toggle state not remembered for tab that has no user conversation is a known issue . Will bring it up with UX for desired flow here. Thanks

This is not just the toggle/UX; Memories are applied in conversations impacted.

(In reply to Punam Dahiya [:pdahiya] from comment #1)

Memory toggle state not remembered for tab that has no user conversation is a known issue . Will bring it up with UX for desired flow here. Thanks

Based on this, does it work correctly if there are conversations with at least 1 message in each chat, Rares? comment #2 makes me think it might not...

Flags: needinfo?(rdoghi)
Attached video ShoeBrands.mp4

This issue occurs for the tabs where there is at least 1 conversation already started, disabling the Memories, going away and coming back to the tab, will still show the Memories as ON, and they are still being used for the next prompt.

Flags: needinfo?(rdoghi)

(In reply to :Gijs (he/him) from comment #3)

(In reply to Punam Dahiya [:pdahiya] from comment #1)

Memory toggle state not remembered for tab that has no user conversation is a known issue . Will bring it up with UX for desired flow here. Thanks

Based on this, does it work correctly if there are conversations with at least 1 message in each chat, Rares? comment #2 makes me think it might not...

My comment #2 should have been 'Memory toggle state not remembered for tab that has no last user conversation with memory disabled is a known issue' . Video in comment #4 has last conversation message in the tab with memory enabled and that got used to decide memory toggle state on switching back to that tab.

Based off UX feedback we want to fix this by capturing toggle state at tab level. Possible it will be a uplift candidate, will start thread in slack on decision around that

Assignee: nobody → ngrato
Status: NEW → ASSIGNED
Pushed by ngrato@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/fe476a04868c https://hg.mozilla.org/integration/autoland/rev/7dd7e6cd555f The Memories button state is not remembered when switching tabs r=omarg,ai-frontend-reviewers
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch

This issue is Verified as fixed in our latest Nightly 151.0a1 (2026-04-15)

QA Whiteboard: [qa-found-in-c151][QA-4747][S3] → [qa-found-in-c151][QA-4747][S3][qa-ver-needed-c151/b150]
QA Contact: rdoghi

The patch landed in nightly and beta is affected.
:ngrato, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(ngrato)
See Also: → 2020878

Just wanted to note fix landed in patch ensures memory toggle tab state is retained when there is at least one message on tab which is reasonable.

Original description #comment 0 of this bug points at tab state is not retained when there is no message (known behavior) and different from #comment 4

Flags: needinfo?(ngrato)

Updating the main status flag.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-found-in-c151][QA-4747][S3][qa-ver-needed-c151/b150] → [qa-found-in-c151][QA-4747][S3][qa-ver-done-c151/b150]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: