2020878 - Sidebar Assistant Memories icon stays toggled off

Status: VERIFIED FIXED

(Core :: Machine Learning: Frontend, defect)

Description

[Punam Dahiya [:pdahiya]]

Attachment: sidebar-assistant-memories-off-state.png

STR

1. Click ask button to open sidebar assistant and toggle memory icon off
2. Right click on any link on the page and open in a new tab
3. Click ask button to open sidebar assistant

ER
Memories icon in sidebar assistant should not be toggled off

AR
Memories icon carries over state from previous tab and stays off

Comment 1

[Chloe Zhou [:chloezhou]]

Attachment: Bug 2020878 - fix memory toggle state lost when switching between tabs r=pdahiya

The memories toggle in the AI sidebar was resetting to the default (on) state
when switching between tabs. This was caused by three issues:

1. The role check in #syncSmartbarMemoriesStateFromConversation compared m.role against the string "user" instead of the numeric MESSAGE_ROLE.USER (0), so it never found the last user message.

2. #syncSmartbarMemoriesStateFromConversation was not called in openConversation, so even when a conversation was restored the toggle state was not synced.

3. The memories toggle state was not preserved across tab switches. The tab state manager now snapshots the sidebar's memoriesToggled value before switching away and restores it after openSidebar completes on the new tab. openSidebar is now awaited since it is async and resets the toggle via onCreateNewChatClick(). #selectedTab is also initialized in #init() so the first tab switch can snapshot correctly.

Comment 2

[Ed Lee :Mardak]

fixed with bug 2016551
https://hg.mozilla.org/mozilla-central/rev/131ea7241723

Comment 3

[Rares Doghi, Desktop QA]

This issue is verified as fixed in our latest Nightly 151.0a1 (2026-03-25) but I did encounter another issue related to it which I filed here : Bug 2026173