2026258 - [Wayland] Right Click and Menu Popups not Rendering

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[alanhdu]

Attachment: about:support text data

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:151.0) Gecko/20100101 Firefox/151.0

Steps to reproduce:

When I use Firefox for an extended amount of time, eventually (e.g. after 30 or so minutes), right click no longer works (no menu is rendered). If I click on a menu (e.g. the Hamburger menu to get to options), nothing gets rendered.

If I pkill firefox and restart, everything works fine for a while. I have not figured out if there is a specific trigger here or if it is time based (it seems to be a bit stochastic but generally happens somewhere within 10-30 minutes of browsing, which is quite frustrating to debug).

This only started happening within the last week or two, and so is probably a pretty recent regression.

I am on Firefox Nightly on Ubuntu.

Actual results:

Nothing gets rendered.

Expected results:

Right click continues to work and menu pop-ups get rendered.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[alanhdu]

Ah -- I think I've figured the trigger out. This happens when I plug in a monitor to my HDMI port (or unplug it) of my laptop. Something about that action must be going wrong with Firefox / Wayland somehow.

Comment 3

[Donal Meehan [:dmeehan]]

This sounds similar to Bug 2026096

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Please attach your about:support page.
Please test latest nightly:
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_Mozilla_Nightly_binaries
Thanks.

Comment 5

[alanhdu]

Attachment: vainfo.txt

Comment 6

[alanhdu]

Attachment: gfxlog.txt

Comment 7

[alanhdu]

I attached the about:support page above as https://bugzilla.mozilla.org/attachment.cgi?id=9558091 -- do you need more information there? I also attached the vainfo.txt and gfxlog.txt from the wiki page.

I went ahead and used the mozregression tool to bisect (neat -- didn't know that existed), which spit out:

 5:59.85 INFO: No more integration revisions, bisection finished.
 5:59.85 INFO: Last good revision: 7a73b5603e29f48cf00cb3e0a1e5f9824785c181
 5:59.85 INFO: First bad revision: b1809ccf86123539ee63bc332d6cf1ac9f0d5dea
 5:59.85 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=7a73b5603e29f48cf00cb3e0a1e5f9824785c181&tochange=b1809ccf86123539ee63bc332d6cf1ac9f0d5dea

Hope that helps!

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Please run Firefox on terminal with MOZ_LOG="WidgetScreen:5,Widget:5,WidgetPopup:5" env variables, reproduce the issue and attach the log here.
Thanks.

Comment 9

[alanhdu]

Attachment: Logs from MOZ_LOG="WidgetScreen:5,Widget:5,WidgetPopup:5"

Added the result of MOZ_LOG="WidgetScreen:5,Widget:5,WidgetPopup:5" firefox-nightly here!

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Thanks a lot! I'd need more info from the log, can you try to run with:

WAYLAND_DEBUG=1 MOZ_LOG="WidgetScreen:5,Widget:5,WidgetPopup:5"

env variables, reproduce the issue and attach the log here?
Thanks.

Comment 11

[Martin Stránský [:stransky] (ni? me)]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #10)

Thanks a lot! I'd need more info from the log, can you try to run with:

WAYLAND_DEBUG=1 MOZ_LOG="WidgetScreen:5,Widget:5,WidgetPopup:5"

env variables, reproduce the issue and attach the log here?
Thanks.

Please run with:

WAYLAND_DEBUG=1 MOZ_LOG="WidgetScreen:5,WidgetWayland:5"

Thanks.

Comment 12

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 2026258 [Wayland] Fall back to wl_output monitor size if we're missing Gtk workarea to calc fractional scale r?emilio

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/cf094fd8726a
https://hg.mozilla.org/integration/autoland/rev/4c169b2a7263
[Wayland] Fall back to wl_output monitor size if we're missing Gtk workarea to calc fractional scale r=emilio

Comment 14

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4c169b2a7263

Comment 15

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:stransky, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox151 to wontfix.

For more information, please visit BugBot documentation.

Comment 16

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Missing popups when monitor is turned off/on (sleep etc.)
• Code covered by automated testing?: no
• Fix verified in Nightly?: no
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing:
• Risk associated with taking this patch: low
• Explanation of risk level: Add fallback to get monitor size from Wayland instead of Gtk - it's still better than nothing.
• String changes made/needed?: none
• Is Android affected?: no

Comment 17

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 2026258 [Wayland] Fall back to wl_output monitor size if we're missing Gtk workarea to calc fractional scale

Original Revision: https://phabricator.services.mozilla.com/D297611

Comment 18

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/137aa85f5963
https://hg.mozilla.org/releases/mozilla-beta/rev/081139401d9b