2026335 - Xbox Wireless Controller has X/Y swapped under Linux (evdev)

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Jeff Muizelaar [:jrmuizel]]

Looks like the same problem as bug 2000789

The IsXpadDevice detection won't work for a bluetooth connected controller.

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: patch

Comment 2

[Tom S. (please needinfo tschuster)]

Sadly it's a bit difficult to find information on how to do this properly and I only have a fake wired X-Box controller. Can you try out the patch?

Comment 3

[Jeff Muizelaar [:jrmuizel]]

What if we just switched to mapping the buttons numerically like Chrome does instead of trying to work around the weird mapping?

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Actually, it seems like Chrome detects the kind of gamepad and maps the buttons appropriately:
https://source.chromium.org/chromium/chromium/src/+/main:device/gamepad/gamepad_standard_mappings_linux.cc;bpv=1;bpt=1

Comment 5

[Miha Lepej [:lepko]]

(In reply to Tom S. (please needinfo tschuster) from comment #2)

Sadly it's a bit difficult to find information on how to do this properly and I only have a fake wired X-Box controller. Can you try out the patch?

I've tested the patch with a Xbox Series X|S controller:
it now returns "xpad" when wired and "microsoft" when wireless (BT)

I'm planning to do some patches this weekend for this and some other issues with Xbox and PS controllers on linux. Would it be ok if i take this bug?

Comment 6

[Miha Lepej [:lepko]]

Attachment: Bug 2026335 - Fix swapped X/Y buttons on Xbox gamepads connected via bluetooth. r?stransky

This is similar to bug 2000789 but for bluetooth controllers.

Co-authored-by: Tom Schuster <[e-mail]>

Comment 7

[Miha Lepej [:lepko]]

I tested with a Xbox 360 wireless controller with the proprietary dongle (360 didn't support BT yet) and it works (xpad driver)
I tested with a Xbox Series X|S controller wired (xpad driver) and wireless (microsoft driver) via BT and both now correctly map the XY buttons.

I'm not sure what the policy is but I added Tom as Co-authored-by in the commit since I based it on his patch. And added stransky as a reviewer since he reviewed the last patch related to these buttons. Hope thats okay.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/8debef160bed
https://hg.mozilla.org/integration/autoland/rev/c5e5c72d42e2
Fix swapped X/Y buttons on Xbox gamepads connected via bluetooth. r=stransky

Comment 9

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/c5e5c72d42e2