Closed Bug 2026775 Opened 3 months ago Closed 23 days ago

[Nova] Implement detached anchor bar container

Categories

(Core :: Machine Learning: Frontend, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
154 Branch
Tracking Status
firefox154 --- fixed

People

(Reporter: jlevinsohn, Assigned: mlucks)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

(Whiteboard: [aidisc])

Attachments

(1 file, 1 obsolete file)

Nova introduces a detached “anchor bar” container that groups the tab strip and toolbar into a single floating surface, visually separated from the web content.

This replaces the current flush layout.

  • Tab strip and toolbar are contained within a single anchor bar container

  • Anchor bar is visually detached from the web content:

    • Not flush with page content
    • Has visible offset from surrounding edges per design
  • Anchor bar spans the full width of the window within defined margins

  • Visual styling matches Nova spec:

    • Background
    • Border / stroke
    • Corner radius
    • Shadow / elevation
  • Styling is correct in both light and dark mode per Nova spec

  • Tab strip and toolbar align correctly within the anchor container (no spacing or clipping issues)

  • No regression to tab or toolbar functionality

  • Layout behaves correctly across window sizes and states

Figma Specs

Important Note

  • Adopt Nova/shared components where available; avoid patching existing customized implementations
  • Remove legacy Smart Window overrides before applying new styling
  • If upstream component already satisfies spec, prefer using it directly
Assignee: nobody → mlucks
Status: NEW → ASSIGNED
Depends on: 2023711
Depends on: 2027859
Attachment #9566404 - Attachment is obsolete: true

Based on chats with the team, it seems like we should inherit most styles from Classic.

Here is their mock for reference.

Differences would include:

  • Toolbar background color
  • Chrome separator color (the border color)
  • Box-shadow applied to the toolbar

I am pending confirmation from UX, which will not happen until the designer in charge is back from vacation (May 26 or around then)

Blocks: 2046199
Depends on: 2046822

Bug 2046822 does not block this work. Associating because without it, the anchor bar/toolbox has broken tabs

Attachment #9588553 - Attachment description: WIP: Bug 2026775 - Nova anchorbar smartwindow updates → Bug 2026775 - Nova anchorbar smartwindow updates - r?gcardieri,emilio
Attachment #9588553 - Attachment description: Bug 2026775 - Nova anchorbar smartwindow updates - r?gcardieri,emilio → Bug 2026775 - Smartwindow Nova Theme implementation with a focus on the toolbar - r?gcardieri,emilio
Flags: needinfo?(emilio)
Flags: needinfo?(emilio)
Pushed by mlucks@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/6c7518f1c00b https://hg.mozilla.org/integration/autoland/rev/b90c9e2d1416 Smartwindow Nova Theme implementation with a focus on the toolbar - r=gcardieri,emilio,desktop-theme-reviewers,tabbrowser-reviewers,robwu,nsharpley
Depends on: 2050893
Status: ASSIGNED → RESOLVED
Closed: 23 days ago
Resolution: --- → FIXED
Target Milestone: --- → 154 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: