Closed Bug 2023711 Opened 4 months ago Closed 2 months ago

Nova styles for floating chrome and sidebar

Categories

(Firefox :: General, task)

Product:
Firefox
Component:
General
Type:
task
Points:
5

Tracking

()

Status:
RESOLVED FIXED
Milestone:
152 Branch
Tracking Flags:
Tracking Status
firefox152 --- fixed

People

(Reporter: sthompson, Assigned: jswinarton)

References

(Depends on 4 open bugs, Blocks 1 open bug)

Details

(Whiteboard: [fidefe-nova])

Attachments

(1 file)

Bug 2023711: Nova styles for floating chrome and sidebar r?dwalker,sthompson
48 bytes, text/x-phabricator-request
Details | Review

UX spec: https://www.figma.com/design/XT0eDYh4RtbMNWaYQi0efM/Chrome-Sidebar-UX-Specifications--Sprint-1-?node-id=10043-83845&t=8JmJB8LIHAYiDTm9-0

  • Menu bar, nav bar, toolbar to utilize previous new border-radius token changes
  • Sidebar launcher and panels with border-radius bump and padding to separate from chrome
  • Splitview/double content window changes
  • Translucent window background
    -- Windows: Media query for -moz-windows-mica will detect when this is supported
    -- macOS: Media query for browser.theme.native-theme and widget.macos.titlebar-blend-mode.behind-window will detect when this is supported and we want to use it
    -- Linux: No specific media query to detect support. 2013682 - Broken subpixel AA and picture caching on linux, due to border-radius on the <body> element to support rounded corners. is a blocker for allowing rounded corners on the window.
    -- Fallback radial gradient background when transparent window not supported
    -- To decide: if a theme sets a background color, should we use that?
    -- To decide: should we add a pref to disable window transparency even when the OS supports it? Some users may prefer not to have transparency.

The Bugbug bot thinks this bug should belong to the 'Firefox::Sidebar' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: General → Sidebar

These styles affect mostly elements of the chrome aside from the sidebar, so I think this unfortunately works best in General.

Component: Sidebar → General
Points: --- → 8
Assignee: nobody → jswinarton
Depends on: 2026246
Depends on: 2026247
Depends on: 2026249
Points: 8 → 5

Work for the translucent background feature has been moved to bug2026246.

Blocks: 2026775
Attachment #9568235 - Attachment description: WIP: Bug 2023711: Nova styles for floating chrome and sidebar → Bug 2023711: Nova styles for floating chrome and sidebar r?dwalker,sthompson
Depends on: 2033594
Depends on: 2034134
Attachment #9568235 - Attachment description: Bug 2023711: Nova styles for floating chrome and sidebar r?dwalker,sthompson → WIP: Bug 2023711: Nova styles for floating chrome and sidebar r?dwalker,sthompson
Attachment #9568235 - Attachment description: WIP: Bug 2023711: Nova styles for floating chrome and sidebar r?dwalker,sthompson → Bug 2023711: Nova styles for floating chrome and sidebar r?dwalker,sthompson
Attachment #9568235 - Attachment description: Bug 2023711: Nova styles for floating chrome and sidebar r?dwalker,sthompson → WIP: Bug 2023711: Nova styles for floating chrome and sidebar r?dwalker,sthompson
Attachment #9568235 - Attachment description: WIP: Bug 2023711: Nova styles for floating chrome and sidebar r?dwalker,sthompson → Bug 2023711: Nova styles for floating chrome and sidebar r?dwalker,sthompson
Blocks: 2037134
Pushed by jswinarton@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d7d0d5a01672 https://hg.mozilla.org/integration/autoland/rev/77cb8888a295 Nova styles for floating chrome and sidebar r=sthompson,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane,dao
Pushed by agoloman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/82df3dd46d4a https://hg.mozilla.org/integration/autoland/rev/5f04d2819e92 Revert "Bug 2023711: Nova styles for floating chrome and sidebar r=sthompson,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane,dao" for causing bc failures @content-area.css.

Backed out for causing bc failures @content-area.css.

Flags: needinfo?(jswinarton)
Pushed by jswinarton@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/02728176088a https://hg.mozilla.org/integration/autoland/rev/cbd53d6a5a10 Nova styles for floating chrome and sidebar r=sthompson,desktop-theme-reviewers,tabbrowser-reviewers,kcochrane,dao

https://hg.mozilla.org/mozilla-central/rev/cbd53d6a5a10

Status: NEW → RESOLVED
Closed: 2 months ago
status-firefox152: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
Depends on: 2038764
Flags: needinfo?(jswinarton)
Depends on: 2038977
Regressions: 2039272
No longer regressions: 2039272
See Also: → 2039272
QA Whiteboard: [qa-triage-done-c153/b152]
Depends on: 2054183
Depends on: 2055329
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: