202684 - Update address autocollection help entries

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Ahmad M. Siddiqi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312

There is no option to add email addresses for incoming messages, although the help says "If you choose "Incoming Mail Messages," Mail & Newsgroups stores the sender's address in each message as soon as you open it.


Reproducible: Always

Steps to Reproduce:
1. Go to Edit | Preferences | Addressing for address collection options.

Actual Results:  
Option not there. Used to be there in earlier Mozilla versions.

Expected Results:  
Displayed an option to allow addition of incoming email addresses as well.

Comment 1

[Claudiu Ionescu]

I have Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.3) Gecko/20030312
There is no option to change preferences to collect incoming e-mail addresses as
it is stipulated in the help.

Comment 2

[Gabriel Seah]

Reporter, can you confirm it was found in previous versions?

I might be wrong, but I think I've never seen the option to add the addresses of incoming senders to the address book.

At any rate, that would mean spammers' emails would clog your address book.

Comment 3

[Joe Infla]

The default behavior described in comment 0 was changed sometime in the 1.1 -
1.3 timeframe for the very reason Gabriel mentioned - spam address accumulation.  

Outgoing message address autocollection is controlled by a pref in Mail &
Newsgroups -> Addressing.  A hidden pref for incoming address autocollection is
still available in about:config, labelled mail.collect_email_address_incoming.

I think the most appropriate resolution to this bug is to update the helpfile.

Helpfile locations to update (navigating from Contents):
Using Mail -> Using Address Books -> Adding Entries to Your Address Books ->
third bullet.
Using Mail -> Mail and Newsgroup Preferences -> Addressing -> first bullet.

Any others?

Comment 4

[Joe Infla]

Attachment: helpfile update - reflect current address collection UI

modified sections mentioned in comment 3; removed references to now hidden
prefs.

Comment 5

[Joe Infla]

Old summary: No option to add senders' email addresses to collected address book

Comment 6

[R.J. Keller]

Comment on attachment 139345 [details] [diff] [review]
helpfile update - reflect current address collection UI

r=[e-mail]

Looks good!

Comment 7

[Joe Infla]

*** Bug 214775 has been marked as a duplicate of this bug. ***

Comment 8

[Giacomo Magnini]

Attachment: Updated patch.

Most of the old patch is not applicable anymore, because was fixed elsewhere. Still, some references needed some polishing to Collected Addresses, so here it is. Probably good for 1.1 also.

Comment 9

[Ian Neal]

Comment on attachment 210684 [details] [diff] [review]
Updated patch.

>Index: extensions/help/resources/locale/en-US/mail_help.xhtml
>===================================================================
>@@ -4613,17 +4613,17 @@ to filter unwanted mail.</p>
>     subcategories are visible, double-click Mail &amp; Newsgroups to expand
>     the list.)</li>
> </ol>
> 
> <ul>
>   <li><strong>Email Address Collection</strong>: Select this if you want Mail
>     &amp; Newsgroups to automatically collect recipients&apos; email addresses.
>     Use the drop-down list to choose between having the addresses added to your
>-    Collected Addresses book or your Personal address book.</li>
>+    Collected Addresses or your Personal address book.</li>
Probably should be "Personal Address Book" (i.e. capitalized).

>   <li id="address_autocompletion"><strong>Address Autocompletion</strong>:
>     Address autocompletion allows you to quickly address mail without having to
>     search for names or type names completely. Select from which location Mail
>     &amp; Newsgroups will search for matching addresses: <q>Local Address
>     Books</q> (Personal Address Book, Collected Addresses Book, or any other
There's one you have missed here "Collected Addresses Book".

Comment 10

[Mark Banner (:standard8)]

Now I've realised what this bug is about (or at least what the patch is doing) you may actually want to hold off a while, as once bug 197138 is implemented, we'll hopefully not have a collected addresses book.

Comment 11

[Giacomo Magnini]

(In reply to comment #10)
> Now I've realised what this bug is about (or at least what the patch is doing)
> you may actually want to hold off a while, as once bug 197138 is implemented,
> we'll hopefully not have a collected addresses book.

From what I understand from that bug, we won't have a CAB by default for new profiles... A clear explanation of what really happens will help in writing a better help! ;)

@Ian: fixed your comments in the mean time... ;)

Can one of you power users add the dependecy on the other bug for this one? I can't.

Comment 12

[Mark Banner (:standard8)]

(In reply to comment #11)
> (In reply to comment #10)
> > Now I've realised what this bug is about (or at least what the patch is doing)
> > you may actually want to hold off a while, as once bug 197138 is implemented,
> > we'll hopefully not have a collected addresses book.
> From what I understand from that bug, we won't have a CAB by default for new
> profiles... A clear explanation of what really happens will help in writing a
> better help! ;)
> @Ian: fixed your comments in the mean time... ;)
> Can one of you power users add the dependecy on the other bug for this one? I
> can't.

I'm not sure we're really going to get to a good decision about bug 197138 soon. I realise we've probably just missed 1.1b and the freeze, but how about we get this in anyway and let this bug be closed down?

Comment 13

[Stefan [:stefanh]]

Giacomo will fix the naming update in bug 313383.

Comment 14

[Giacomo Magnini]

Fixed by checkin for bug 313383 (trunk and branch).

Comment 15

[Stefan [:stefanh]]

Really fixed ;-)