Closed Bug 2027793 Opened 4 months ago Closed 3 months ago

“New” badge persists after using Split View

Categories

(Firefox :: Tabbed Browser: Split View, defect, P1)

Firefox 149
defect

Tracking

()

VERIFIED FIXED
151 Branch
Tracking Status
relnote-firefox --- 150+
firefox150 --- verified
firefox151 --- verified

People

(Reporter: yurivkhan, Assigned: jsudiaman)

References

Details

(Whiteboard: [fidefe-splitview])

Attachments

(2 files)

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:149.0) Gecko/20100101 Firefox/149.0

Steps to reproduce:

  1. on a clean profile, or after upgrade to 149 from a previous version
  2. Select two tabs by clicking one, Ctrl+clicking another.
  3. Right-click one of the two selected tabs.
  4. Choose “Open in Split View [New]” from the context menu.
  5. Right-click the resulting grouped tab.
  6. Choose “Separate Split View [New]” from the context menu.
  7. Repeat steps 1–4.

Actual results:

Steps 2, 4, 6.2, 6.4 display the “New” badge.

Expected results:

Steps 2, 4 display the “New” badge, because they are a new feature that the user might not be aware of yet.

Steps 6.2, 6.4 no longer display the badge, as the user has confirmed awareness by interacting with the new feature.

See also bug 2001940

Workaround: #context_moveTabToSplitView::after, #context_separateSplitView::after { display: none !important; } in userChrome.css.

Ideal world expected results: New features require no promotion. Users become aware of them by noticing them through day-to-day interaction, or by word of mouth, or by (horror!) reading the release notes.

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser: Split View' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Component: Untriaged → Tabbed Browser: Split View

There are some posts about this on reddit, since there is no "easy" way to remove the "new"-badge.

Bug 2000075 added a removeNewBadge method, but did not make the calls conditional, similar to the tabs-notes feature.
As the feature is already live making the badge conditional, now, seems like a waste of time.

Flags: needinfo?(sthompson)
Flags: needinfo?(jswinarton)

Bug 1986946 added the new badge to the split view content menu items unconditionally. Bug 2000075 updated that implementation, but the badging is still unconditional.

Our UX guidelines https://acorn.firefox.com/latest/desktop/components/badge-xbYTPKlB-xbYTPKlB#section-beta-and-new-duration-rules-60 state that new badges should be:

  1. only shown for 2 or 3 releases
  2. should no longer be shown when the user interacts with the feature

There is an existing browser.tabs.splitview.hasUsed pref that could be used to conditionally add the new badge.

Based on the 2-3 release guideline, the new badge should be removed entirely from the codebase with Firefox 151 or 152.

Flags: needinfo?(sthompson)
Flags: needinfo?(jswinarton)
Severity: -- → S3
Status: UNCONFIRMED → NEW
Ever confirmed: true
Priority: -- → P1
Whiteboard: [fidefe-splitview]

We'll remove this entirely for Firefox 152.

(In reply to Jonathan Sudiaman [:jsudiaman] from comment #6)

We'll remove this entirely for Firefox 152.

By “this entirely”, do you mean the whole New badge and the practice of displaying it on every new menu item?

Because if you mean the New badge for this one individual feature, then 152 is way too late.

Seeing a New badge in the menu once per feature is distracting. Twice is annoying. Several times a day, every day, for three months, is outrageous.

Do we have a way to permanently opt out of any new New badges?

(In reply to Yuri Khan from comment #7)

(In reply to Jonathan Sudiaman [:jsudiaman] from comment #6)

We'll remove this entirely for Firefox 152.

By “this entirely”, do you mean the whole New badge and the practice of displaying it on every new menu item?

Because if you mean the New badge for this one individual feature, then 152 is way too late.

Seeing a New badge in the menu once per feature is distracting. Twice is annoying. Several times a day, every day, for three months, is outrageous.

Do we have a way to permanently opt out of any new New badges?

Per Stephen's comment, the behavior of showing the badge unconditionally (even after interaction) is not intended. That does need to be fixed.

To answer your question, there is not currently a way to opt out of "New" badges entirely.

Blocks: 2031788
Assignee: nobody → jsudiaman
Status: NEW → ASSIGNED
Pushed by jsudiaman@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3085b16e88aa https://hg.mozilla.org/integration/autoland/rev/96c3a752b967 Fix “New” badge persists after using Split View r=tabbrowser-reviewers,sthompson
Status: ASSIGNED → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch

firefox-release Uplift Approval Request

  • User impact if declined/Reason for urgency: Users constantly see a "New" badge on Split View items in the context menu, despite having already interacted with the Split View feature.
  • Code covered by automated testing?: yes
  • Fix verified in Nightly?: no
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: https://bugzilla.mozilla.org/show_bug.cgi?id=2027793#c0
  • Risk associated with taking this patch: low
  • Explanation of risk level: The fix is contained in gBrowser.updateContextMenu() which makes the calls to addNewBadge() conditional.
  • String changes made/needed?: None
  • Is Android affected?: no
Attachment #9574262 - Flags: approval-mozilla-release?
Flags: qe-verify+
QA Whiteboard: [qa-triage-done-c152/b151][qa-ver-needed-c152/b151]
QA Whiteboard: [qa-triage-done-c152/b151][qa-ver-needed-c152/b151] → [qa-triage-done-c152/b151][uplift][qa-ver-needed-c152/b151]
Attachment #9574262 - Flags: approval-mozilla-release? → approval-mozilla-release+

Verified that the Split View New badge is no longer displayed with Firefox 151.0b4 on Windows 11, macOS 26 and Ubuntu 24 after it was used once.
Also, I see that using the Add Split View context menu option once also removes the New badge from the Separate Split View context menu option. Asking to be sure if this is intentional? Thank you!

QA Whiteboard: [qa-triage-done-c152/b151][uplift][qa-ver-needed-c152/b151] → [qa-triage-done-c152/b151][uplift][qa-ver-done-c152/b151]
Flags: qe-verify+ → needinfo?(jsudiaman)

(In reply to Alexandru Trif, Desktop Test Engineering [:atrif] from comment #15)

Verified that the Split View New badge is no longer displayed with Firefox 151.0b4 on Windows 11, macOS 26 and Ubuntu 24 after it was used once.
Also, I see that using the Add Split View context menu option once also removes the New badge from the Separate Split View context menu option. Asking to be sure if this is intentional? Thank you!

Thanks for verifying!

Yes, any interaction with Split View should remove the New badge from all Split View items.

Flags: needinfo?(jsudiaman)

Verified fixed with Firefox 150.0.2 on Windows 11, macOS 26 and Ubuntu 24 that the SplitView New badge disappears after first use on a new profile.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: