2027836 - Add a pull request number parameter to Github graphs

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Andrew Halberstadt [:ahal]]

We've started running some tasks on PRs to mozilla-firefox/firefox. Having the PR number as a parameter will allow the code review bot to comment with the result summary.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2027836 - [ci] Add test parameters for 'mozilla-firefox/firefox' pull requests, r?#taskgraph-reviewers

Comment 2

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2027836 - [ci] Add a pull request parameter for Github graphs, r?#taskgraph-reviewers

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3e527d7c940b
https://hg.mozilla.org/integration/autoland/rev/a129aeba9fd8
[ci] Add test parameters for 'mozilla-firefox/firefox' pull requests, r=taskgraph-reviewers,bhearsum
https://github.com/mozilla-firefox/firefox/commit/c3215c55497e
https://hg.mozilla.org/integration/autoland/rev/3597958559b3
[ci] Add a pull request parameter for Github graphs, r=taskgraph-reviewers,releng-reviewers,bhearsum

Comment 4

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/a129aeba9fd8
https://hg.mozilla.org/mozilla-central/rev/3597958559b3

Comment 5

[Andrew Halberstadt [:ahal]]

Looks like I missed adding it to the schema

Comment 6

[Andrew Halberstadt [:ahal]]

Attachment: Bug 2027836 - [ci] Add 'pull_request_number' to graph config schema, r?#taskgraph-reviewers

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/1d3cdeca2397
https://hg.mozilla.org/integration/autoland/rev/694e61311c6b
[ci] Add 'pull_request_number' to graph config schema, r=taskgraph-reviewers,bhearsum

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/772678a514f0
https://hg.mozilla.org/integration/autoland/rev/c29422683ba6
Revert "Bug 2027836 - [ci] Add 'pull_request_number' to graph config schema, r=taskgraph-reviewers,bhearsum" for causing ci failures

Comment 9

[rperta]

and also those rpk failures

Comment 10

[Julien Cristau [:jcristau]]

The failure in comment 9 can be fixed by

diff --git a/taskcluster/gecko_taskgraph/parameters.py b/taskcluster/gecko_taskgraph/parameters.py
index 4b74a1583207..84550a1b6617 100644
--- a/taskcluster/gecko_taskgraph/parameters.py
+++ b/taskcluster/gecko_taskgraph/parameters.py
@@ -139,7 +139,6 @@ def get_defaults(repo_root=None):
         "optimize_strategies": None,
         "phabricator_diff": None,
         "project": "mozilla-central",
-        "pull_request_number": None,
         "release_enable_emefree": False,
         "release_enable_partner_repack": False,
         "release_enable_partner_attribution": False,

(the schema says pull_request_number can be either absent or an int, but it can't be null, afaict)

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0f410739b39d
https://hg.mozilla.org/integration/autoland/rev/4aaff14752c8
[ci] Add 'pull_request_number' to graph config schema, r=taskgraph-reviewers,bhearsum

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/9f09862171f7
https://hg.mozilla.org/integration/autoland/rev/fc8361675281
Revert "Bug 2027836 - [ci] Add 'pull_request_number' to graph config schema, r=taskgraph-reviewers,bhearsum" for causing ci failures.

Comment 13

[Atila Butkovits]

Backed out for causing ci failures.

Backout link: https://hg.mozilla.org/integration/autoland/rev/fc8361675281

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&searchStr=linux%2C24.04%2Copt%2Csource-test-python-firefox-ci%2Cci&revision=4aaff14752c8bb83c1901a995aa4150b0e9d89d2&selectedTaskRun=Dk9rmMvPQ8G4HsOPdK3KfA.0

Failure log:
https://firefoxci.taskcluster-artifacts.net/Dk9rmMvPQ8G4HsOPdK3KfA/0/public/logs/live_backing.log
https://treeherder.mozilla.org/logviewer?job_id=557709180&repo=autoland&task=IWfj096eRSOYot1zJ14ZWw.0&lineNumber=422

Comment 14

[Andrew Halberstadt [:ahal]]

Oops, looks like my try push has a different commit than the phab revision

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7968d1fa0198
https://hg.mozilla.org/integration/autoland/rev/78069054d446
[ci] Add 'pull_request_number' to graph config schema, r=taskgraph-reviewers,bhearsum

Comment 16

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/78069054d446