2027915 - Disable the legacy Edge migrator

Status: RESOLVED FIXED

(Firefox :: Migration, task, P3)

Description

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

Before we do a removal, we can start by disabling the Edge Legacy migrator by default. This migrator is controlled via browser.migrate.edge.enabled.

Comment 1

[:Gijs (he/him)]

Is this actionable today? Should/could it be a mentored bug?

Comment 2

[Mike Conley (:mconley) (:⚙️) (PTO June 8 - 12)]

I got the go-ahead from Ania to start with disablement. I'll go ahead and mark this as mentorable.

Hello interested contributor! This should be a very straight-forward bug, involving a default pref flip. Mainly, we aim to flip this value to false: https://searchfox.org/firefox-main/rev/23974e2d947e31e4ae42ae2758a4416c9a6d8671/browser/app/profile/firefox.js#2725

We'll also want to re-enable it for these two tests by adding this line below each Edge test entry here and here

prefs = ["browser.migrate.edge.enabled=true"]

Example: https://searchfox.org/firefox-main/rev/23974e2d947e31e4ae42ae2758a4416c9a6d8671/browser/components/newtab/test/xpcshell/xpcshell.toml#30

And finally, we'll need to re-enable the migrator for this test, by adding this to the top of the test file, after the "use strict" line:

add_setup(async () => {
  // The EdgeHTML Edge migrator is disabled by default.
  await SpecialPowers.pushPrefEnv({
    set: [["browser.migrate.edge.enabled", true]],
  });
});

Comment 3

[Anthony Mclamb]

Attachment: Bug 2027915 - Disable the legacy edge migration. r=mconley

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d55713733ac9
https://hg.mozilla.org/integration/autoland/rev/088c18b0c74e
Disable the legacy edge migration. r=mconley,migration-reviewers

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/088c18b0c74e