Closed Bug 2028575 Opened 13 days ago Closed 6 days ago

Ensure that MAR channels are correctly retrieved by unelevated update processes on macOS

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Platform:
All
macOS
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
151 Branch
Tracking Flags:
Tracking Status
firefox-esr115 --- wontfix
firefox-esr140 150+ fixed
firefox149 --- wontfix
firefox150 + fixed
firefox151 + fixed

People

(Reporter: spohl, Assigned: spohl, NeedInfo)

References

(Regression)

Details

(Keywords: regression)

Attachments

(2 files, 1 obsolete file)

Bug 2028575: Ensure that MAR channels are correctly retrieved by unelevated update processes on macOS. r=#application-update-reviewers
48 bytes, text/x-phabricator-request
Details | Review
Bug 2028575: Ensure that MAR channels are correctly retrieved by unelevated update processes on macOS.
48 bytes, text/x-phabricator-request
phab-bot
: approval-mozilla-esr140+
Details | Review

Bug 1890764 introduced a regression for elevated updates in which unelevated update processes may crash due to gMARStrings not being properly populated before being accessed. Patch coming up.

Set release status flags based on info from the regressing bug 1890764

status-firefox149: --- → affected
status-firefox150: --- → affected
status-firefox151: --- → affected
status-firefox-esr140: --- → affected
Summary: Ensure that MAR channels can be retrieved from unelevated update processes on macOS → Ensure that MAR channels are correctly retrieved by unelevated update processes on macOS
Blocks: 2015697
See Also: → 1893500
See Also: → 1975334
See Also: → 2028602
Attachment #9563226 - Attachment description: WIP: Bug 2028575: Ensure that MAR channels are correctly retrieved by unelevated update processes on macOS. → Bug 2028575: Ensure that MAR channels are correctly retrieved by unelevated update processes on macOS.
Attachment #9563226 - Attachment description: Bug 2028575: Ensure that MAR channels are correctly retrieved by unelevated update processes on macOS. → Bug 2028575: Ensure that MAR channels are correctly retrieved by unelevated update processes on macOS. r=#application-update-reviewers

This is a major bug affecting our .pkg installers. We should uplift as far as possible. Tentatively setting to S2 for awareness. n-i :cdupuis for awareness and review, or redirect to someone who could review the patch. Thank you!

Severity: -- → S2
Flags: needinfo?(cdupuis)

Robin, maybe you can take a look or forward as needed? I'd like to land this as soon as possible and request uplifts. Thank you!

Flags: needinfo?(bytesized)
Flags: needinfo?(cdupuis)
Flags: needinfo?(bytesized)
Pushed by spohl@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/0a70fa69bfee https://hg.mozilla.org/integration/autoland/rev/5e00907d34f0 Ensure that MAR channels are correctly retrieved by unelevated update processes on macOS. r=application-update-reviewers,cdupuis

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: This has the potential to break updates on macOS and is particularly relevant for enterprise and other users who rely on the .pkg installer, hence the request to uplift to ESR as well.
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: This is a well-understood regression from bug 1890764 with a straightforward fix.
  • String changes made/needed?: none
  • Is Android affected?: no
Attachment #9567380 - Flags: approval-mozilla-beta?

firefox-esr140 Uplift Approval Request

  • User impact if declined/Reason for urgency: This has the potential to break updates on macOS and is particularly relevant for enterprise and other users who rely on the .pkg installer, hence the request to uplift to ESR as well.
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing:
  • Risk associated with taking this patch: low
  • Explanation of risk level: This is a well-understood regression from bug 1890764 with a straightforward fix.
  • String changes made/needed?: none
  • Is Android affected?: no
Attachment #9567382 - Flags: approval-mozilla-esr140?
Pushed by abutkovits@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/fc4bdf5b5754 https://hg.mozilla.org/integration/autoland/rev/6eeaaa1b4151 Revert "Bug 2028575: Ensure that MAR channels are correctly retrieved by unelevated update processes on macOS. r=application-update-reviewers,cdupuis" for causing failures at marMissingUpdateSettings.js.
Pushed by spohl@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/da1953a5820f https://hg.mozilla.org/integration/autoland/rev/8840bd21e4ea Ensure that MAR channels are correctly retrieved by unelevated update processes on macOS. r=application-update-reviewers,cdupuis

https://hg.mozilla.org/mozilla-central/rev/8840bd21e4ea

Status: ASSIGNED → RESOLVED
Closed: 6 days ago
status-firefox151: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
Attachment #9567380 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9567380 - Attachment is obsolete: true
Attachment #9567382 - Flags: approval-mozilla-esr140? → approval-mozilla-esr140+
QA Whiteboard: [qa-triage-done-c151/b150]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: