Closed Bug 2028765 Opened 7 months ago Closed 5 months ago

Turn off events telemetry mirror

Categories

(Firefox :: Remote Settings Client, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox153 --- fixed

People

(Reporter: leplatrem, Assigned: leplatrem)

References

Details

Attachments

(1 external file)

Telemetry now rely on Glean, and Legacy Telemetry definitions can now be removed.

common/uptake-telemetry.sys.mjs used to be a generic helper to report uptake of different components, in a unified way.

Since Bug 1918702, it is hard-coded for RemoteSettings and Normandy.

Since Bug 2021439, it is hard-coded for RemoteSettings only.

Let's clean this up, and move everything to services/settings since it's not generic anymore, and can't be leveraged by arbitrary components anymore.

It used to have fixed status values, but since Bug 1620175 histograms were migrated to events, and telemetry can now report any status. Let's remove the unused foreseen errors like CUSTOM_2_ERROR etc.

Assignee: nobody → mathieu
Attachment #9563485 - Attachment description: WIP: Bug 2028765 - Remove legacy uptake Telemetry → Bug 2028765 - Remove legacy uptake Telemetry r?chutten,acottner
Status: NEW → ASSIGNED
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/4679debc4283 https://hg.mozilla.org/integration/autoland/rev/556ce0e90547 Revert "Bug 2028765 - Remove legacy uptake Telemetry r=chutten,acottner" for causing xpcshells failures at uptake_telemetry.js

Backed out for causing xpcshells failures at uptake_telemetry.js
Backout Link
Push with failures
Failure Log
Failure log for TV
Failure line:
TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_uptake_telemetry.js | xpcshell return code: 0

Flags: needinfo?(mathieu)
Regressions: 2030972
Regressions: 2031504
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/94d5923d36b0 https://hg.mozilla.org/integration/autoland/rev/31f0c0180938 Revert "Bug 2028765 - Remove legacy uptake Telemetry r=chutten,acottner" for causing xpcshell failures in test_uptake_telemetry.js.

Reverted this because it was causing xpcshell failures in test_uptake_telemetry.js.

  • Revert link
  • Push with failures
  • Failure Log
  • Failure line: TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_uptake_telemetry.js | test_age_is_converted_to_string_and_reported - [test_age_is_converted_to_string_and_reported : 197] parent must be in snapshot. Has []. - false == true

There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:leplatrem, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.

Flags: needinfo?(mathieu)
Flags: needinfo?(chutten)
Flags: needinfo?(chutten)
Pushed by asilaghi@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/3c09c5159f63 https://hg.mozilla.org/integration/autoland/rev/8a3b2f1ba6a9 Revert "Bug 2028765 - Remove legacy uptake Telemetry r=chutten,acottner" for causing xpcshells failures at /test_attachments_downloader.js

Backed out for causing xpcshells failures
Backout Link
Push with failures
Failure Log xpcshells
XPC
Failure Log TV
Failure line TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_attachments_downloader.js | test_downloader_reports_download_errors - [test_downloader_reports_download_errors : 223] number of uptake events () - 0 == 2
TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_remote_settings.js | test_throws_when_network_is_offline - [test_throws_when_network_is_offline : 168] number of uptake events () - 0 == 2

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Flags: needinfo?(mathieu)
QA Whiteboard: [qa-triage-done-c154/b153]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: