Turn off events telemetry mirror
Categories
(Firefox :: Remote Settings Client, enhancement)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox153 | --- | fixed |
People
(Reporter: leplatrem, Assigned: leplatrem)
References
Details
Attachments
(1 external file)
Telemetry now rely on Glean, and Legacy Telemetry definitions can now be removed.
common/uptake-telemetry.sys.mjs used to be a generic helper to report uptake of different components, in a unified way.
Since Bug 1918702, it is hard-coded for RemoteSettings and Normandy.
Since Bug 2021439, it is hard-coded for RemoteSettings only.
Let's clean this up, and move everything to services/settings since it's not generic anymore, and can't be leveraged by arbitrary components anymore.
It used to have fixed status values, but since Bug 1620175 histograms were migrated to events, and telemetry can now report any status. Let's remove the unused foreseen errors like CUSTOM_2_ERROR etc.
| Assignee | ||
Comment 1•7 months ago
|
||
Updated•7 months ago
|
Comment 4•7 months ago
|
||
Backed out for causing xpcshells failures at uptake_telemetry.js
Backout Link
Push with failures
Failure Log
Failure log for TV
Failure line:
TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_uptake_telemetry.js | xpcshell return code: 0
Comment 7•7 months ago
|
||
Reverted this because it was causing xpcshell failures in test_uptake_telemetry.js.
- Revert link
- Push with failures
- Failure Log
- Failure line: TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_uptake_telemetry.js | test_age_is_converted_to_string_and_reported - [test_age_is_converted_to_string_and_reported : 197] parent must be in snapshot. Has []. - false == true
| Assignee | ||
Comment 8•7 months ago
|
||
I don't get it. all xpcshell tests ran successfully on https://treeherder.mozilla.org/jobs?repo=try&revision=05cd81f77688762cb5407d68aeaa81d56092e5ee&selectedTaskRun=Hmg8hsZlRLGNM0s5SUrtIg.0
Comment 9•6 months ago
|
||
There is an r+ patch which didn't land and no activity in this bug for 2 weeks.
:leplatrem, could you have a look please?
If you still have some work to do, you can add an action "Plan Changes" in Phabricator.
For more information, please visit BugBot documentation.
Updated•6 months ago
|
Comment 10•6 months ago
|
||
Comment 11•6 months ago
|
||
Comment 12•6 months ago
•
|
||
Backed out for causing xpcshells failures
Backout Link
Push with failures
Failure Log xpcshells
XPC
Failure Log TV
Failure line TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_attachments_downloader.js | test_downloader_reports_download_errors - [test_downloader_reports_download_errors : 223] number of uptake events () - 0 == 2
TEST-UNEXPECTED-FAIL | services/settings/test/unit/test_remote_settings.js | test_throws_when_network_is_offline - [test_throws_when_network_is_offline : 168] number of uptake events () - 0 == 2
Comment 13•5 months ago
|
||
Comment 14•5 months ago
|
||
| bugherder | ||
| Assignee | ||
Updated•5 months ago
|
Updated•5 months ago
|
Description
•