Closed Bug 2028995 Opened 13 days ago Closed 8 days ago

Add a Translate menu item to the more-tools section of the application menu

Categories

(Firefox :: Translations, enhancement)

enhancement

Tracking

()

RESOLVED FIXED
151 Branch
Tracking Status
relnote-firefox --- ?
firefox151 --- fixed

People

(Reporter: nordzilla, Assigned: nordzilla)

Details

Attachments

(3 files)

Description

The about:translations page is officially launching in Firefox 150 with a URL-bar QuickAction to help with discoverability.

In order to further improve discoverability, the Translations team would like to add a "Translate" menu item to the "More Tools" section of the Application Menu (see screenshot for an example).

This menu item, when invoked, will also lead to the about:translations page, just like the Translate QuickAction does.

This bug refactors the functionality that opens the about:translations
page into the TranslationsUtils static scope, so that it can be shared
among other entry points that lead to the page. Currently, the only entry
point is the Translate QuickAction. The next commit adds a second entry
point to the Application Menu.

This commit introduces a new menu item to the more-tools section
of the Application Menu (three-bar humburger menu) within Firefox
Desktop, which leads to the about:translations page when invoked
similar to the Translate QuickAction in the URL bar.

Attached image example.png
Attachment #9563871 - Attachment description: WIP: Bug 2028995 - Move about:translations open function to TranslationsUtils → WIP: Bug 2028995 - Add openAboutTranslationsPage function
Attachment #9563871 - Attachment description: WIP: Bug 2028995 - Add openAboutTranslationsPage function → Bug 2028995 - Add openAboutTranslationsPage function
Attachment #9563872 - Attachment description: WIP: Bug 2028995 - Add Translate to the more-tools ection of the app menu → Bug 2028995 - Add Translate to the more-tools ection of the app menu
Attachment #9563872 - Attachment description: Bug 2028995 - Add Translate to the more-tools ection of the app menu → Bug 2028995 - Add Translate to the more-tools section of the app menu
Pushed by enordin@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8e4b5cc340d3 https://hg.mozilla.org/integration/autoland/rev/f61bb5d10e2b Add openAboutTranslationsPage function r=urlbar-reviewers,daleharvey https://github.com/mozilla-firefox/firefox/commit/6d06afb66fdf https://hg.mozilla.org/integration/autoland/rev/5025347d4d66 Add Translate to the more-tools section of the app menu r=translations-reviewers,fluent-reviewers,bolsson,gregtatum
Status: NEW → RESOLVED
Closed: 8 days ago
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch

Did you want to nominate this for the Fx151 relnotes? Go ahead and do so if yes.

Flags: needinfo?(enordin)

(In reply to Ryan VanderMeulen [:RyanVM] from comment #6)

Did you want to nominate this for the Fx151 relnotes? Go ahead and do so if yes.

Sure, it's a small thing, but I don't think that it could hurt to add it to the release notes.


Release Note Request (optional, but appreciated)

[Why is this notable]: This is a new entry point for accessing the about:translations page.

[Suggested wording]: The about:translations page is now accessible through the More Tools section of the Application Menu.

(I will populate something with a screenshot in the 151 draft doc.)

relnote-firefox: --- → ?
Flags: needinfo?(enordin)

Thanks, added to the Fx151 nightly release notes, please allow 30 minutes for the site to update.
Keeping the relnote-firefox flag as ? to keep it on the radar for inclusion in the final Fx151 release notes.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: