2037850 - `AppMenu > More tools > Translate...` remains available when browser.translations.enable is set to false

Status: VERIFIED FIXED

(Firefox :: Translations, defect)

Description

[aoia7rz7l]

Tested on Nightly 152.0a1(2026-05-06) BuildID 20260506210744.

Prerequisite:

browser.translations.enable is set to false.

STR:

Open AppMenu > More tools.

Expected Behavior:

All translation-related controls are disabled when browser.translations.enable is set to false.

Actual Behavior:

AppMenu > More tools > Translate... remained available despite browser.translations.enable being set to false.

Mozregression returned

Last good revision: b053db0979de666e4933ca64c90229f0bb7f1457
First bad revision: 5025347d4d6642c538301906889151452cc6bcf3
Pushlog: https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b053db0979de666e4933ca64c90229f0bb7f1457&tochange=5025347d4d6642c538301906889151452cc6bcf3

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Translations' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Erik Nordin [:nordzilla]]

I'm going to resolve this as a duplicate of Bug 2037853, since they effectively describe the same thing. This way we can centralize our conversation.

Comment 3

[Erik Nordin [:nordzilla]]

Actually, I've misread this bug.

This is for the "More tools" menu item, not the top-level menu item.

Comment 4

[Erik Nordin [:nordzilla]]

Attachment: disabled-ui.png

I'm confirming that the "More tools" translate menu item does not disappear as it should.

That was an oversight on my part. Thankfully, this code is in Firefox Beta 151, and there is still time to fix it.

Secondly, even when it is clicked, you are met with a disabled UI (see screenshot).

Comment 5

[Erik Nordin [:nordzilla]]

Attachment: Bug 2037850 - Hide More-Tools Translate when Translations is disabled r=sfoster!

This commit ensures that the "Translate" menu item in the "More Tools"
section of the Application Menu is properly hidden when the Translations
feature becomes disabled.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a4f828f04f62
https://hg.mozilla.org/integration/autoland/rev/ab2bac68f2fb
Hide More-Tools Translate when Translations is disabled r=sfoster

Comment 7

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/ab2bac68f2fb

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:nordzilla, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox151 to wontfix.

For more information, please visit BugBot documentation.

Comment 9

[Erik Nordin [:nordzilla]]

Attachment: Bug 2037850 - Hide More-Tools Translate when Translations is disabled

This commit ensures that the "Translate" menu item in the "More Tools"
section of the Application Menu is properly hidden when the Translations
feature becomes disabled.

Original Revision: https://phabricator.services.mozilla.com/D299140

Comment 10

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: The "More Tools" section of the Application Menu will still have a "Translate..." menu item even when Translations is turned off in AI Controls. This will lead to the about:translations page, which has its own user messaging that the feature is blocked so this isn't the worst scenario. However, I think users who turn Translations off may not want to see this menu item at all.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: 1) Start with Translations enabled.

2. Open the top-corner Application Menu

3. Open the "More Tools" section.

4. Verify that the "Translate..." menu item is available.

5. Navigate to about:settings#ai

6. Block Translations

7. Repeat steps 2) and 3)

8. Verify that the "Translate..." menu item is no longer available.

• Risk associated with taking this patch: low
• Explanation of risk level: This is a small change with automated test coverage.
• String changes made/needed?: N/A
• Is Android affected?: no

Comment 11

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/3212ea4ccc09
https://hg.mozilla.org/releases/mozilla-beta/rev/fefc7c884f67

Comment 12

[Monica Chiorean]

I was able to reproduce the issue on Win11x64 using Firefox build 152.0a1(20260506210744).
Verified as fixed on Win11x64 using Firefox build 152.0a1(20260510213110). Waiting for next beta to confirm the fix in beta also.

Comment 13

[Monica Chiorean]

Verified as fixed on Win11x64/Mac15.5/Ubuntu24.04 using FF build 151.0b9 (20260511090442).