2029604 - ‘Password saved!’ message is not displayed when saving credentials

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect)

Description

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Notess

• The logins are saved properly; only the 'Password saved!' toast message is missing.
• Reproducible on a new profile.

*Found in

• Beta 150.0b5;

Affected versions

• Nightly 151.0a1;
• Beta 150.0b5;

Tested platforms

• macOS 15;
• Ubuntu 22;
• Windows 11;

Affected platforms

• macOS 15;
• Ubuntu 22;
• Windows 11;

Unaffected platforms

• N/A;

Steps to reproduce

1. Launch Firefox.
2. Go to https://www.facebook.com and fill both the username and password fields with credentials.
3. Click on the key icon on the left of the address bar and click on ‘Save’ button.

Expected result

• ”Password saved!” message is displayed.

Actual result

• ”Password saved!” message is not displayed.

Regression range

• last good: 2025-12-09;
• first bad: 2025-12-10;
• pushlog: https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=2e4d12d1471579bddffa06c27b3f516201c44631&tochange=31298ba1737e850dcf67963349d8168198c5b458
• potentially regressed by: bug 1988726

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1988726

:daleharvey, since you are the author of the regressor, bug 1988726, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Dale Harvey (:daleharvey)]

Attachment: Bug 2029604 - Ensure password notifications are shown when trustPanel enabled

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/bfc29241d4d1
https://hg.mozilla.org/integration/autoland/rev/daa3491abdbf
Ensure password notifications are shown when trustPanel enabled r=credential-management-reviewers,dimi

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/daa3491abdbf

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daleharvey, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Dale Harvey (:daleharvey)]

Nominated for beta uplift

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: A user facing confirmation is missing which may lead to used confusion.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Launch Firefox.
  Go to https://www.facebook.com and fill both the username and password fields with credentials.
  Click on the key icon on the left of the address bar and click on ‘Save’ button.
• Risk associated with taking this patch: low
• Explanation of risk level: Small patch covered by automated tests
• String changes made/needed?: N/A
• Is Android affected?: yes

Comment 9

[Dale Harvey (:daleharvey)]

Attachment: Bug 2029604 - Ensure password notifications are shown when trustPanel enabled

Original Revision: https://phabricator.services.mozilla.com/D292410

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/88da44f45081
https://hg.mozilla.org/releases/mozilla-beta/rev/f9fb90f6c177

Comment 11

[Mira Lobontiu (Android QA)]

Verified as fixed on the latest Firefox for Android Beta 150.0b9, and on Nightly 151.0a1, with an Oppo Find N2 Flip (Android 15).

Comment 12

[Ardelean Oana, Desktop Test Engineering [:oardelean]]

Reproducible on a 2026-04-06 Firefox Nightly build on Windows 10.

Verified as fixed on Firefox Nightly 151.0a1 and Firefox 150.0b9 on Windows 10, Ubuntu 22, macOS 15.