2030165 - [HDR/Windows] Allowlist HDR video on AMD/NVIDIA drivers as they support HLG transfer function

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect, P1)

Description

[Ashley Hale [:ahale]]

Currently we know that HLG->PQ conversion doesn't work in VideoProcessor on some drivers (particularly Intel), so we need to blocklist the HDR video feature on these drivers to ship as websites like YouTube don't distinguish between HLG and PQ videos so we can't tell them that we support only one or the other, and displaying HLG as BT709 transfer function does work but is not a great user experience compared to the default SDR behavior with already-tonemapped videos.

We can reduce this blocklist coverage once we have our own HLG->PQ shader in place.

Another approach that would be an improvement is to just attempt setting up the VideoProcessor during startup and see if it works, we do something like that for a few codecs already.

Comment 1

[Ashley Hale [:ahale]]

Note that we don't necessarily need to forbid showing PQ video as HDR, the capability works fine on these drivers, it's just that we can't advertise the media capability because we don't do HLG on these drivers.

Comment 2

[Ashley Hale [:ahale]]

Attachment: Bug 2030165 - Allow HDR video on Windows only on AMD/NVIDIA initially r?#gfx-reviewers

Comment 3

[Ashley Hale [:ahale]]

Allowlist patch is awaiting review, once it lands I will land the patch to enable in release, and we can uplift both to beta.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/5f426b833c9f
https://hg.mozilla.org/integration/autoland/rev/491589e631f0
Allow HDR video on Windows only on AMD/NVIDIA initially r=gfx-reviewers,bradwerth,aosmond

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/b6345dd2a813
https://hg.mozilla.org/integration/autoland/rev/0ed14616102b
Revert "Bug 2030165 - Allow HDR video on Windows only on AMD/NVIDIA initially r=gfx-reviewers,bradwerth,aosmond" for causing crashtest failures at gfxFeature

Comment 6

[Silaghi Andreea]

Backed out for causing multiple failures at gfxFeature
Backout Link
Push with failures
Failure Log wpt
BC
WD
Failure line Assertion failure: IsInitialized(), at checkouts/gecko/gfx/config/gfxFeature.h:140

Comment 7

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: HDR video on Windows is a top priority feature for Firefox 151.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: yes
• Needs manual QE testing?: no
• Steps to reproduce for manual QE testing: Manual testing is already organized for this feature.
• Risk associated with taking this patch: low
• Explanation of risk level: This disables HDR video processing for GPU vendors that we have not verified handle HLG video correctly yet - it makes it less likely that we have to roll back HDR video in general.
• String changes made/needed?: None
• Is Android affected?: no

Comment 8

[Ashley Hale [:ahale]]

Attachment: Bug 2030165 - Allow HDR video on Windows only on AMD/NVIDIA initially

Original Revision: https://phabricator.services.mozilla.com/D296087

Comment 9

[Ashley Hale [:ahale]]

Attempting to land the patch on autoland and requested beta uplift, manually tested on two Windows PCs (one Intel Tigerlake iGPU, as well as trying it on NVIDIA as primary GPU, and on a purely AMD desktop), a Macbook Pro M4, and a Linux Wayland PC, the Intel iGPU worked as expected (HDR video disabled, and if forced the HLG video showed as non-HDR, and PQ worked fine), the AMD GPU worked as expected (full functionality), and the Macbook worked correctly, and Linux Wayland did not work but that is expected as we're not shipping there yet (problems observed: on an HLG video the browser crashed with an unsupported transfer function error, on a PQ video the video showed as non-HDR, turning on layer compositor did not improve either of these behaviors).

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/494e31d4a5f1
https://hg.mozilla.org/integration/autoland/rev/14c76df2019c
Allow HDR video on Windows only on AMD/NVIDIA initially r=gfx-reviewers,win-reviewers,bradwerth,aosmond,gstoll

Comment 11

[Ashley Hale [:ahale]]

Attachment: Bug 2030165 - Allow HDR video on Windows only on AMD/NVIDIA initially

Original Revision: https://phabricator.services.mozilla.com/D296087

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/14c76df2019c

Comment 13

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/dc4699790233
https://hg.mozilla.org/releases/mozilla-beta/rev/492202d5e6e9