Closed Bug 2030686 Opened 2 days ago Closed 1 day ago

Ship Interventions v151.3.0 out-of-band

Categories

(Web Compatibility :: Interventions, task)

Firefox 151

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: twisniewski, Unassigned)

References

(Blocks 2 open bugs)

Details

It's Train Hoppin' time! This time, the release drivers are bug 2026464 and bug 1986438, as well as us wanting to verify that train-hopping was not somehow broken by the fix in bug 2019069. The interventions are already built and due to ship in the next Nightly, in the mentioned bugs. Uplift requests are to be considered.

Build was successful, here is the link to the dep-signed .xpi.

I have tested the dep-signed xpi in an unbranded release build on macOS and confirmed that the interventions work as expected to un-break the front page of https://f1store.formula1.com and keep a "works best on" banner from appearing when visiting https://gamma.app/create/paste. Added my sign off on ShipIt.

Dennis tested and signed off as well, and we have a release-signed XPI with version 151.3.20260409.134825. I just confirmed that visiting the same two URLs in comment 1 works as expected for me with that XPI on a regular release build.

hneiva, can you take the webcompat-151.3.0-build1 release from Ship-It and get that into the release-sysaddon channel - for Desktop on all platforms, targeting Release 149.* and Beta 150.*, please? We don't need a rule for Nightly 151, since the new intervention is already shipping in the next Nightly.

When it's on the staging channel, I'll provide release testing instructions here so that we can run our update testing again.

Flags: needinfo?(hneiva)

The rules for webcompat-151.3.0-build1 were created and serving for 149.* and 150.* on the release-sysaddon channel.

Flags: needinfo?(hneiva)

Testing steps for the current release build. For testing in beta, replace release-sysaddon with beta-sysaddon, everything else remains.

  1. Open a fresh profile, do not use your main profile for this.
  2. Go to https://gamma.app/create/paste and verify that you see the "works best in Chrome" banner.
  3. Open about:config, edit extensions.systemAddon.update.url, and set it to https://aus5.mozilla.org/update/3/SystemAddons/%VERSION%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/release-sysaddon/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/update.xml
  4. Open the Firefox DevTools. In the DevTools, open the Settings via the Three-Dot-Menu -> Settings. In there, enable the checkbox Enable browser chrome and add-on debugging toolboxes.
  5. Open the Firefox Browser Console:
    • on Linux and Windows, press Ctrl+Shift+J to open it
    • on macOS, it's Cmd+Shift+J
  6. In that new console, run ChromeUtils.importESModule("resource://gre/modules/AddonManager.sys.mjs", { global: "shared" }).AddonManagerPrivate.backgroundUpdateCheck();
  7. You won't see any progress, the update happens in the background. Wait 30 seconds, just to make sure Firefox has enough time to download and apply all updates.
  8. Head to about:support, search for "Web Compatibility Interventions", and check that the version number shows 151.3.20260409.134825
  9. Verify in a private tab that the "works best in" banner on https://gamma.app/create/paste is no longer there.
  10. Verify in a private tab that https://f1store.formula1.com successfully loads.
  11. Restart Firefox, keeping the same profile. Verify that the version number in about:support is still 151.3.20260409.134825, and that steps 9 and 10 still work.

I've tested the fix on windows, linux, and macos, and while f1tv's store doesn't actually have the problem on Linux, it's best to ship this fix in case that happens there as well in the future.

I run the steps from comment 4 and confirm that it works as expected on macOS and Windows.

Not directly related to this OOB update, but worth noting regarding https://f1store.formula1.com:
There is another subdomain https://f1store4.formula1.com (that turns out to be the first search result in google), and if I clear cookies for both domains, and visit it first, https://f1store.formula1.com starts returning 403. So we need to exclude f1store4 as well in the next updates of the addon.

Good catch, Ksenia. Thanks. For now, our testing is green, so we can ship this whenever folks are ready.

Heitor, can you help get the sign-offs for that? (We want to target release for 149., as well as beta and aurora for 150.)

Flags: needinfo?(hneiva)

"promoted" beta and release rules and created Aurora rule. Tagged RelMan for approval.

Flags: needinfo?(hneiva)

It looks like the updates are live now. I've prepared a telemetry query to keep an eye on the numbers (Mozilla-staff-only link).

Status: NEW → RESOLVED
Closed: 1 day ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.