2031237 - [wdspec] Update continue_request/cookies.py to match the specification

Status: RESOLVED FIXED

(Remote Protocol :: WebDriver BiDi, task, P3)

Description

[Julian Descottes [:jdescottes]]

As discussed in https://github.com/w3c/webdriver-bidi/issues/1110, the current tests in continue_request/cookies.py don't match the specification and they expect cookies updated in network.beforeRequestSent to show up in the cookies property of later events (network.responseStarted, network.responseCompleted, ...).

We should update the test to assert the following instead:

• if a new cookie unknown to the cookie store is added, it will not be present in the cookies property
• if the value of a cookie already present is modified, the value in the cookies property will not reflect the modification
• if a cookie is removed (via rewriting the header completely), the cookie will not show up in the cookies property (because in that case, the cookie is no longer included in the request)

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 2031237 - [wdspec] Update network/continue_request/cookies.py to match specification about modified cookies

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a6d8b35e2dd0
https://hg.mozilla.org/integration/autoland/rev/8c1a81ff6ab1
[wdspec] Update network/continue_request/cookies.py to match specification about modified cookies r=whimboo

Comment 3

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/8c1a81ff6ab1

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/59604 for changes under testing/web-platform/tests

Comment 5

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot