2031595 - [meta] Review logic errors in remote folder found by static analysis (claude)

Status: NEW

(Remote Protocol :: Agent, task)

Description

[Julian Descottes [:jdescottes]]

Asked claude to perform a quick static analysis of the remote codebase and it found the following issues

• marionette/actors/MarionetteCommandsChild.sys.mjs:195 — this.#finalizeAction() called without await in receiveMessage; the response may be returned before finalization completes.
• messagehandler/RootMessageHandler.sys.mjs:227 — iterates a realms Set while calling realms.delete(realm.realm) (a property value) instead of realms.delete(realm) — entries are never actually removed.
• messagehandler/MessageHandlerRegistry.sys.mjs:165-167 — getExistingMessageHandler called with two arguments but only accepts one; the type argument is silently ignored.
• webdriver-bidi/modules/windowglobal/browsingContext.sys.mjs:48 — assigns to this.contextCreatedHandled (public) instead of this.#contextCreatedHandled (private field declared at line 34).

I quickly checked and they all seem valid, could make for good mentored bugs. The two first ones are the only concerning issues, the last two are just cleanup.