2031598 - Fix MessageHandlerRegistry.sys.mjs calling getExistingMessageHandler with an unused second argument

Status: RESOLVED FIXED

(Remote Protocol :: Agent, task, P3)

Description

[Julian Descottes [:jdescottes]]

The second argument at https://searchfox.org/firefox-main/rev/8332a06d47ce7d66623d807068b3410061cd29d3/remote/shared/messagehandler/MessageHandlerRegistry.sys.mjs#165-168

const rootMessageHandler = this.getExistingMessageHandler(
  sessionId,
  lazy.RootMessageHandler.type
);

is unused so it can be removed. But looking at the code, getRootMessageHandler is not used at the moment so I suggest to completely remove the method.

This is a simple code removal, if anyone wants to get an easy first contribution to setup the environment, this could be a good bug !

Comment 1

[Armin Ulrich]

Hi, I would like to work on this. As you said, perfect for setting up the environment.

Comment 2

[Julian Descottes [:jdescottes]]

Sounds good Armin, you can follow the instructions on https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html to get started. The bug will be automatically assigned to you as soon as you submit a patch for it on Phabricator!

Comment 3

[Armin Ulrich]

(In reply to Julian Descottes [:jdescottes] from comment #2)

Sounds good Armin, you can follow the instructions on https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html to get started. The bug will be automatically assigned to you as soon as you submit a patch for it on Phabricator!

Great, I will get to it after work. Thanks!

Comment 4

[Armin Ulrich]

Attachment: Bug 2031598 - Remove unused function getRootMessageHandler. r?jdescottes

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/4065d26b6e35
https://hg.mozilla.org/integration/autoland/rev/4c9e4dbb504e
Remove unused function getRootMessageHandler. r=jdescottes

Comment 6

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/4c9e4dbb504e