2031834 - Remove scrollframe capturing-content special-case.c

Status: RESOLVED FIXED

(Core :: DOM: Events, defect, P3)

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 2031834 - Restrict odd capturing-content special-case to listboxes. r=masayuki,smaug

This goes back to bug 519693. I recently stumbled across it because in
bug 2031757 I'm making text controls a scrollable frame (to fix a
variety of compat issues and make field-sizing easy to implement).

This special case breaks the capturing that HTMLInputElement does for
the button spinners (because it sets the <input> as capturing content
and that is now scrollable, but the spinners live outside the
scrolled frame because they don't scroll with the content).

First, it seems odd to return a non-root (viewport or popup) frame on a
function that claims to do so. Removing it also doesn't seem to cause
any issues (the original problem doesn't reproduce). Finally, it'd be
really inconsistent to do this only if the capturing frame is a
scrollframe itself, not if any ancestor is, or somesuch...

Try to restrict this hack to listboxes.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Attachment: web exposed different behavior

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/a394d26763ff
https://hg.mozilla.org/mozilla-central/rev/37e15b839432
Restrict odd capturing-content special-case to listboxes. r=smaug

Comment 4

[rperta]

https://hg.mozilla.org/mozilla-central/rev/37e15b839432