2032237 - [meta] Add all Nova icons to the codebase

Status: NEW

(Firefox :: Theme, task)

Description

[Stephen Thompson [:sthompson]]

Add the new icons to a new location in the codebase so that the existing icons can still be used without any changes. The new icons should be opt-in based on the Nova pref. The new icons should all adhere to the canonical Acorn name, e.g. checkmark-circle-fill-16, camera-16, audio-muted-12.

• toolkit/themes/shared/icons/nova for more broadly used icons
• browser/themes/shared/icons/nova for Firefox-specific icons

For component-specific icons under browser/themes/* (notification-icons, privatebrowsing, tabbrowser, controlcenter, preferences), consider placing the new Nova icons next to the existing icon files instead of shared/icons/

The New Tab team will need its own copies of updated icons.

Based on the current estimate that 174 SVGs in the codebase need updated assets and their total file size is 176 KB, the updated assets would add an additional 176 KB to the Firefox install size until the pre-Nova icons are deleted.

This bug will be complete once all of the updated icons are landed.

Comment 1

[Sam Foster [:sfoster] (he/him)]

(In reply to Stephen Thompson [:sthompson] from comment #0)

Add the new icons to a new location in the codebase so that the existing icons can still be used without any changes. The new icons should be opt-in based on the Nova pref. The new icons should all adhere to the canonical Acorn name, e.g. checkmark-circle-fill-16, camera-16, audio-muted-12.

Just to note our convention has been to omit the size suffix if it is the default, e.g. checkmark-circle-fill-16 > checkmark-circle-fill.svg.

Comment 2

[Stephen Thompson [:sthompson]]

Thank you for the reminder. I'd like to reconsider that convention. For the vast majority of icons, the asset is intended to be used at a specific pixel size. I think it would be useful for icon users to have that explicit signal in the icon asset name without having to understand a naming convention.