2041515 - Add Nova icons for Firefox :: Address Bar

Status: RESOLVED FIXED

(Firefox :: Address Bar, task)

Description

[Stephen Thompson [:sthompson]]

There are a small number of icons owned by Address Bar. These should display in the Nova icon style when Nova is enabled.

• flight-airline.svg has a redrawn icon, but the inflight progress animation is not being updated
• the market up/down/unchanged icons are probably out of scope for updates
• the sports icons have been redrawn for Nova

Inventory: https://docs.google.com/spreadsheets/d/1ytaedsgOuplUL5bDrCjt4tdteok6-wMoz-oW5OQL0yk/edit?gid=1091359864#gid=1091359864

Comment 1

[Stephen Thompson [:sthompson]]

Attachment: Bug 2041515 - urlbar Nova icons r=#urlbar-reviewers!

Displays the Nova iconography when browser.nova.enabled is true.

Updates 9 existing urlbar icons with the following approach:

1. wraps the existing <path>(s) in a <g class="proton">
2. appends the Nova redrawn icon's <path>(s) in a <g class="nova">
3. adds a <style> block with rules to show only one group at a time

This is an unorthodox approach. It has several drawbacks:

1. increases individual SVG size
2. increases the time required to render each SVG
3. viewing the SVGs in normal image tools will only show the Proton variant, which is confusing

However, I think this approach is better than alternatives.

1. do not need to add new Nova icon files and CSS rules to use them conditionally
2. SVG uses in XHTML and similar contexts doesn't require special handling
3. this can be undone very easily after Nova is released, leaving only the Nova paths
4. the SVG rendering performance impact is not large, and alternatives would still have non-zero performance impact
5. total size of SVGs is not that much larger than if we added separate Nova icons

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/e07fecf25a5c
https://hg.mozilla.org/integration/autoland/rev/24b214c96e28
urlbar Nova icons r=urlbar-reviewers,desktop-theme-reviewers,dao

Comment 3

[amarc]

https://hg.mozilla.org/mozilla-central/rev/24b214c96e28