2032602 - Update Share submenu in the tab context menu on Windows

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, enhancement)

Description

[Ania]

Attachment: windows share submenu in the tab context menu

As we bring tab context menus to consistency across platforms and to reduce the number of clicks necessary to copy a link, we would like to change the behavior of the Share tab context menu item on Windows:

Current behavior
Clicking Share opens Microsoft Sharing dialog.

New behavior
Clicking Share opens submenu with the options to copy link, generate a QR code of the selected link, and open Microsoft sharing system

Share menu sub-options for a single tab:

• Copy Link
• Generate QR code
• Open Microsoft System Sharing

Sub-options for multiple tabs selected:

• Copy X Links
• Generate QR code should be greyed out
• Open Microsoft System Sharing

Telemetry:
We currently use metric browser.ui.interaction.tabs_context to record interactions with the tab context menu.
Let's please continue using this one and record the following labels for this metric:

• click on the top-level Share option | label: tab-context-share-url (we already record it on Windows and macOS)
• copy single link | label: context-copy-url | was implemented for macOS in 150
• copy multiple links | label: copy-multiple-links | was implemented for macOS in 150
• generate qr code | label: generate-qr-code | there's a separate counter implemented for this action, but it seems to be useful to track this within this metric
• open Microsoft system sharing | label: microsoft-system-share

Comment 1

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 2032602 - Update SharingUtils code to populate share menu on all platforms. r=gijs

Comment 2

[Harshit Sohaney [:hsohaney]]

Attachment: Bug 2032602 - (Part 2) Testing SharingUtils code to populate share menu on all platforms. r=gijs

Comment 3

[klower]

Hi Harshit - Discussing with Ania, we'd like to make one string change here, to update:

Open Microsoft System Sharing
to
More Options

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/3fae4433dbe8
https://hg.mozilla.org/integration/autoland/rev/d231acd5682f
Update SharingUtils code to populate share menu on all platforms. r=fluent-reviewers,urlbar-reviewers,bolsson,Gijs,dao
https://github.com/mozilla-firefox/firefox/commit/d508367ad496
https://hg.mozilla.org/integration/autoland/rev/8273b372a92a
(Part 2) Testing SharingUtils code to populate share menu on all platforms. r=Gijs

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/37dbfb48c868
https://hg.mozilla.org/integration/autoland/rev/f8c4628a8509
Revert "Bug 2032602 - (Part 2) Testing SharingUtils code to populate share menu on all platforms. r=Gijs" for causing bc failures.

Comment 6

[agoloman]

Backed out for causing bc failures.

• Backout link
• Push with failures
• Failure Log

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/14d92362adf9
https://hg.mozilla.org/integration/autoland/rev/d4088039ab86
Update SharingUtils code to populate share menu on all platforms. r=fluent-reviewers,urlbar-reviewers,bolsson,Gijs,dao
https://github.com/mozilla-firefox/firefox/commit/f50ac45d3f45
https://hg.mozilla.org/integration/autoland/rev/1bbc88620c13
(Part 2) Testing SharingUtils code to populate share menu on all platforms. r=Gijs

Comment 8

[Harshit Sohaney [:hsohaney]]

Hey Ania, a quick note that the patch here also fixes the bug for linux (bug 2032598)!

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/c6d6de0c7535
https://hg.mozilla.org/integration/autoland/rev/5e75027b1ee3
Revert "Bug 2032602 - (Part 2) Testing SharingUtils code to populate share menu on all platforms. r=Gijs" for causing conflicts on modules/SharingUtils.sys when trying to backout Bug 2033243

Comment 10

[Iulian Moraru]

Backout merged to central: https://hg-edge.mozilla.org/mozilla-central/rev/5e75027b1ee3

Comment 11

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/d4088039ab86
https://hg.mozilla.org/mozilla-central/rev/1bbc88620c13

Comment 12

[Harshit Sohaney [:hsohaney]]

Hey, why was this backed out? Were there test failures?

Comment 13

[rperta]

(In reply to Harshit Sohaney [:hsohaney] from comment #12)

Hey, why was this backed out? Were there test failures?

It was backed out for causing conflicts when I tried backing out Bug 2033243, there were no issues with the latest changeset pushed by you!

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/72d7474c273c
https://hg.mozilla.org/integration/autoland/rev/bd3897926c74
Update SharingUtils code to populate share menu on all platforms. r=fluent-reviewers,urlbar-reviewers,bolsson,Gijs,dao
https://github.com/mozilla-firefox/firefox/commit/008142fc1dca
https://hg.mozilla.org/integration/autoland/rev/61dba576459d
(Part 2) Testing SharingUtils code to populate share menu on all platforms. r=Gijs

Comment 15

[Harshit Sohaney [:hsohaney]]

thanks!

Comment 16

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/bd3897926c74
https://hg.mozilla.org/mozilla-central/rev/61dba576459d

Comment 17

[Ania]

Release Note Request (optional, but appreciated): 152
[Why is this notable]: Share submenu previously didn't exist on Linux, and on Windows, and users couldn't copy a link from the tab context menu on Linux at all. On Windows, users had to invoke the system share sheet to do something as simple as copying a link.
[Suggested wording]: On Windows and Linux, you can now copy links via the tab context menu by right-clicking a tab and selecting Share > Copy Link – making it easy to copy a link without switching to the tab first. When multiple tabs are selected, you can copy all selected links at once. Windows users still retain access to Microsoft sharing options from the Share menu.
[Affects Firefox for Android]: No
[Links (documentation, blog post, etc)]: N/A

Not sure if it's important for rel notes, but this ticket included both Windows work and Linux work ticketed separately here.

Mark, I wanted to make sure the release note looks good to you given that there was some confusion with the copy multiple links in the past.

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Added to the Fx152 relnotes, happy to update as needed.