2033231 - Middle clicking alternate engines no longer perform a search on the current search bar text in a new tab

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Alice0775 White]

Steps to reproduce:

1. Click on searchmode switcher icon in the new searchbar to open alternate engines dropdown list.
2. Middle mouse click on alternate engines in the dropdown list

Actual results:
Nothing happens

Expected results:
Should open a search results with the selected alternate engine(Bug 2011220) in a new background tab(Bug 2025746)

Regression window:
https://hg-edge.mozilla.org/integration/autoland/pushloghtml?fromchange=873a00f344743bb314c75893ea1f79581490374b&tochange=c17b1ffbd81f7acc18f9571c3b72c8b0732d45f2

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:mbeier, since you are the author of the regressor, bug 1998985, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Donal Meehan [:dmeehan]]

[Tracking Requested - why for this release]:

Comment 3

[Moritz Beier [:mbeier]]

Hm, this really should have been caught by tests. I guess I should have requested changes instead of accepting here: https://phabricator.services.mozilla.com/D289509#inline-1577156

Comment 4

[Moritz Beier [:mbeier]]

Attachment: Bug 2033231 - Middle clicking alternate engines no longer perform a search on the current search bar text in a new tab. r?dao

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1998985

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/0774035e0bc3
https://hg.mozilla.org/integration/autoland/rev/ea33007225ef
Middle clicking alternate engines no longer perform a search on the current search bar text in a new tab. r=dao,urlbar-reviewers

Comment 7

[amarc]

https://hg.mozilla.org/mozilla-central/rev/ea33007225ef

Comment 8

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: Users can't start searches with alternative search engines in new tabs using the mouse only (would have to use the accel key on the keyboard).
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: See https://bugzilla.mozilla.org/show_bug.cgi?id=2033231#c0
• Risk associated with taking this patch: low
• Explanation of risk level: Middle click handling was already there, this patch only adds the middle click listener + tests.
• String changes made/needed?: no
• Is Android affected?: no

Comment 9

[Moritz Beier [:mbeier]]

Attachment: Bug 2033231 - Middle clicking alternate engines no longer perform a search on the current search bar text in a new tab.

Original Revision: https://phabricator.services.mozilla.com/D295835

Comment 10

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/b5d49a7c603b
https://hg.mozilla.org/releases/mozilla-beta/rev/638adcdec3fe

Comment 11

[Petruta Horea [:phorea]]

Reproduced using Firefox 151 beta 1.
Verified as fixed on Nightly 152.0a1 under Win 11, Ubuntu 24 and macOS 15.

Comment 12

[Petruta Horea [:phorea]]

Verified as fixed using Firefox 151 beta 3 across macOS 15, Win 11 and Ubuntu 24.