Closed Bug 1998985 Opened 6 months ago Closed 24 days ago

Convert XUL in SearchModeSwitcher to HTML

Categories

(Firefox :: Address Bar, task, P1)

Product:
Firefox
Component:
Address Bar
Version:
Firefox 146
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
151 Branch
Tracking Flags:
Tracking Status
firefox151 --- fixed

People

(Reporter: mbeier, Assigned: mbeier)

References

(Blocks 3 open bugs)

Details

(Whiteboard: [sng][mcab-hnt])

Attachments

(1 file, 2 obsolete files)

Bug 1998985 - Convert XUL in SearchModeSwitcher to HTML. r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,tgiles,bolsson,dao
48 bytes, text/x-phabricator-request
Details | Review
No description provided.
Priority: -- → P3
Severity: -- → N/A
Blocks: 2002830
No longer blocks: 1974218
Component: Search → Address Bar
Blocks: 2010269
Assignee: nobody → mbeier
Status: NEW → ASSIGNED
Depends on: 2026268
No longer blocks: 2002830
Depends on: 2026264
Attachment #9559384 - Attachment is obsolete: true
Blocks: 2026560
Attachment #9556160 - Attachment description: WIP: Bug 1998985 - Part 1: Use HTML elements for everything except search mode switcher. r?dao → Bug 1998985 - Part 1: Use HTML elements for easy parts in urlbar. r?dao
Attachment #9556161 - Attachment description: WIP: Bug 1998985 - Part 2: Use HTML elements for search mode switcher. r?dao → Bug 1998985 - Part 2: Use HTML elements for search mode switcher. r?dao
Whiteboard: [sng] → [sng][mcab-hnt]
Flags: qe-verify+
Priority: P3 → P1
Summary: Convert XULElements in UrlbarInput to HTMLElements → Convert XUL in SearchModeSwitcher to HTML
Depends on: 2030983

Comment on attachment 9556160 [details]
Bug 1998985 - Part 1: Use HTML elements for easy parts in urlbar. r?dao

Revision D289160 was moved to bug 2030983. Setting attachment 9556160 [details] to obsolete.

Attachment #9556160 - Attachment is obsolete: true
Attachment #9556161 - Attachment description: Bug 1998985 - Part 2: Use HTML elements for search mode switcher. r?dao → Bug 1998985 - Convert XUL in SearchModeSwitcher to HTML. r?dao
Pushed by mbeier@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/d472cdc25d3f https://hg.mozilla.org/integration/autoland/rev/3c21700c62b3 Convert XUL in SearchModeSwitcher to HTML. r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,tgiles,bolsson,dao
Pushed by rperta@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/e40fbe050fcd https://hg.mozilla.org/integration/autoland/rev/c792a06e7ea7 Revert "Bug 1998985 - Convert XUL in SearchModeSwitcher to HTML. r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,tgiles,bolsson,dao" for causing assertion failures at BindingUtils.cpp

Backed out for causing assertion failures at BindingUtils.cpp
Backout link
Push with failures
Failure log(s)

Flags: needinfo?(mbeier)
Attachment #9556161 - Attachment description: Bug 1998985 - Convert XUL in SearchModeSwitcher to HTML. r?dao → Bug 1998985 - Convert XUL in SearchModeSwitcher to HTML. r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,tgiles,bolsson,dao
Pushed by mbeier@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/c7e3915280e6 https://hg.mozilla.org/integration/autoland/rev/7741c34d7f08 Convert XUL in SearchModeSwitcher to HTML. r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,tgiles,bolsson,dao
Pushed by sstanca@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/8ed0e7e1a079 https://hg.mozilla.org/integration/autoland/rev/00e4ca899ff4 Revert "Bug 1998985 - Convert XUL in SearchModeSwitcher to HTML. r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,tgiles,bolsson,dao" for causing several linux tier 2 failures.

Reverted this because it was causing several linux tier 2 failures.

Pushed by mbeier@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/b00b0f1cb176 https://hg.mozilla.org/integration/autoland/rev/c17b1ffbd81f Convert XUL in SearchModeSwitcher to HTML. r=fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,urlbar-reviewers,tgiles,bolsson,dao
Blocks: 2031029
Blocks: 2032017
Regressions: 2032020
Blocks: 2032048
Regressions: 2032052

https://hg.mozilla.org/mozilla-central/rev/c17b1ffbd81f

Status: ASSIGNED → RESOLVED
Closed: 24 days ago
status-firefox151: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 151 Branch
Flags: needinfo?(mbeier)
Regressions: 2032196
QA Whiteboard: [search] [qa-triage-done-c151/b150]
Blocks: 2032373
Regressions: 2032381
Regressions: 2033231
Regressions: 2033862
Depends on: 2036022
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: