2033285 - When Browsing history is selected in Delete browsing data on quit, open tabs are also cleared

Status: VERIFIED FIXED

(Firefox for Android :: History, defect)

Description

[Denys [:denyshon]]

Steps to reproduce

1. Have some open tabs
2. In Settings, to to "Delete browsing data on quit".
3. Check "Browsing history" and uncheck everything else (including "Open tabs").
4. Quit Firefox

Expected behavior

Open tabs are not closed (since this option is unchecked).

Actual behavior

Open tabs are closed with no option to recover.

Device information

• Firefox version: 151.0a1
• Android device model: Redmi Note 7 Pro.
• Android OS version: 10QKQ1.190915.002

Any additional information?

This is a regression in Nightly (v151). Doesn't reproduce in Beta or Release.

Comment 1

[Denys [:denyshon]]

[Tracking Requested - why for this release]:

Comment 2

[BugBot [:suhaib / :marco]]

:alastun, since you are the author of the regressor, bug 2015391, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 3

[BugBot [:suhaib / :marco]]

Set release status flags based on info from the regressing bug 2015391

Comment 4

[BugBot [:suhaib / :marco]]

The bug is marked as tracked for firefox151 (beta). However, the bug still isn't assigned.

:calu, could you please find an assignee for this tracked bug? Given that it is a regression and we know the cause, we could also simply backout the regressor. If you disagree with the tracking decision, please talk with the release managers.

For more information, please visit BugBot documentation.

Comment 5

[Cathy Lu [:calu]]

Hey alastun, can you take a look at this and set the severity?

Comment 6

[Rebeca Tudor]

Attachment: Bug 2033285 - Ensure open tabs are not cleared when the option is not selected for deletion on quit.

Comment 7

[Donal Meehan [:dmeehan]]

We are in the final full week of beta for Fx151.
Rebace, hopefully, there are no concerns this week with landing the patch and requesting beta uplift?

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/6bb725fd7a32
https://hg.mozilla.org/integration/autoland/rev/65eb4aaca4a9
Ensure open tabs are not cleared when the option is not selected for deletion on quit. r=android-reviewers,twhite

Comment 9

[Phabricator Automation]

firefox-beta Uplift Approval Request

• User impact if declined/Reason for urgency: This patch fixes a regression. Without this patch, the users will get the open tabs closed when they use Quit even if they didn't select this configuration.
• Code covered by automated testing?: yes
• Fix verified in Nightly?: no
• Needs manual QE testing?: yes
• Steps to reproduce for manual QE testing: Case 1:
  Steps to reproduce

1. Enable "Delete browsing data on quit".
2. Make sure "Browsing history" is checked.
3. Open several tabs and close some of them.
4. Quit Firefox.
5. Reopen Firefox.

Expected behavior
The "Recently closed tabs" section in History is empty, because the whole history has been cleared.

Case 2:
Steps to reproduce

1. Have some open tabs
2. In Settings, to to "Delete browsing data on quit".
3. Check "Browsing history" and uncheck everything else (including "Open tabs").
4. Quit Firefox

Expected behavior
Open tabs are not closed (since this option is unchecked).

• Risk associated with taking this patch: low
• Explanation of risk level: There aren't any risks associated with this patch.
• String changes made/needed?: No.
• Is Android affected?: yes

Comment 10

[Rebeca Tudor]

Attachment: Bug 2033285 - Ensure open tabs are not cleared when the option is not selected for deletion on quit.

Original Revision: https://phabricator.services.mozilla.com/D296987

Comment 11

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/65eb4aaca4a9

Comment 12

[Pulsebot]

https://github.com/mozilla-firefox/firefox/commit/4a0ed6cc7555
https://hg.mozilla.org/releases/mozilla-beta/rev/5c398aa16f8f

Comment 13

[Vasilica Tamas (Android QA) [:vtamas]]

Attachment: Recording_20260507_111300.mp4

This issue is verified as fixed on Firefox for Android 152 Nightly (2026-05-06) and Firefox 151 beta 7 on Samsung S24 Ultra with Android 16. Confirming that the tabs remains opened when deleting the browsing history using the "Delete browsing data on quit" method.