2015391 - Recently closed tabs persist when Browsing history is selected in Delete browsing data on quit

Status: VERIFIED FIXED

(Firefox for Android :: History, defect)

Description

[Denys [:denyshon]]

Steps to reproduce

1. Enable "Delete browsing data on quit".
2. Make sure "Browsing history" is checked.
3. Open several tabs and close some of them.
4. Quit Firefox.
5. Reopen Firefox.

Expected behavior

The "Recently closed tabs" section in History is empty, because the whole history has been cleared.

Actual behavior

The "Recently closed tabs" section content persists.

Device information

• Firefox version: 149.0a1
• Android device model: Redmi Note 7 Pro
• Android OS version: 10

Any additional information?

Initially brought up here.

Comment 1

[Noah Bond [:007]]

We likely are missing the clean-up logic for Recently Closed for this specific case.

This is the function we should invoke during this browsing history tear down operation.

https://searchfox.org/firefox-main/source/mobile/android/android-components/components/feature/recentlyclosed/src/main/java/mozilla/components/feature/recentlyclosed/RecentlyClosedTabsStorage.kt#78

Comment 2

[lj]

Actually I think this is a regression in Firefox for Android 148.0, althugh it is being reported against 149. I am seeing this exact issue starting with 148.0. Previously, using Firefox for Android 147.0.4, all 'recently closed tabs' were cleared when I quit Firefox, but starting with 148.0 they are still there next time I start. (I do have Delete browsing data on quit set to ON, and do have Browsing History and Open Tabs checked.)

Comment 4

[alinlastun]

Attachment: Bug 2015391 - Persistent Recently Closed Tabs by implementing parallel history deletion and RAM state clearing

Use parallel execution (supervisorScope) to prevent SQLite deletion from blocking BrowserStore dispatches during app termination.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/ad67575d7ed5
https://hg.mozilla.org/integration/autoland/rev/84731130f194
Persistent Recently Closed Tabs by implementing parallel history deletion and RAM state clearing r=android-reviewers,rebecatudor273,twhite

Comment 6

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/84731130f194

Comment 7

[Anthony]

Could we request an uplift please?

Comment 8

[alinlastun]

(In reply to Anthony from comment #7)

Could we request an uplift please?

We could, but this fix is only part of two major bugs in this category, the latter being more important: [link]. I was thinking we should fix both and then do the uplift.

Comment 9

[Denys [:denyshon]]

(The link above is broken, but it should lead to bug 1992645)

Comment 10

[BugBot [:suhaib / :marco]]

Since nightly and release are affected, beta will likely be affected too.
For more information, please visit BugBot documentation.

Comment 11

[BugBot [:suhaib / :marco]]

The patch landed in nightly and beta is affected.
:alastun, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox150 to wontfix.

For more information, please visit BugBot documentation.

Comment 13

[Rebeca Tudor]

QA could you please verify if this bug was fixed? There seems to be users who still get the issue. The patch is already in Beta, so both Nightly and Beta should be tested. Thank you!

Comment 14

[Lorand Janos]

Verified as fixed on the latest Nightly 152.0a1 and on the latest Beta (151.0b2) builds.

The "Recently closed tabs" section in History is empty, because the whole history has been cleared.

Devices used:

• Samsung Galaxy S25 Ultra (Android 16);
• Xiaomi Mi11 Lite (Android 11).