2033441 - Reduce Page Protection: Don't show in perma private browsing mode

Status: RESOLVED FIXED

(Core :: Privacy: Anti-Tracking, task, P2)

Description

[Manuel Bucher [:manuel]]

Perma private browsing mode looks like normal browsing mode. For the first iteration I'd like to keep it from showing in the default window someone is using.

Comment 1

[Manuel Bucher [:manuel]]

Attachment: Bug 2033441 - Reduce Page Protection: Don't show in perma private browsing mode

Comment 2

[Manuel Bucher [:manuel]]

Reasoning: With current heuristic this would show too often in perma private browsing (one reload on pages with blocked trackers). So for permanent PBM users will see it too much. We can revisit if we adjust the heuristic a bit more. For now we've decided to stay with the heuristic, but offer the button to disable the feature entirely.

We're going to collect telemetry on disablement. And also get qualitative feedback via connect.mozilla.org. If we are going to revisit the heuristic, we can also revisit whether to enable in perma private-browsing.

Comment 3

[Manuel Bucher [:manuel]]

Attachment: Bug 2033441 - Reduce Page Protection: Test that infobar doesn't show up in permanent browsing r=#anti-tracking

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/76f03c4d319e
https://hg.mozilla.org/integration/autoland/rev/b73c6ae641f1
Reduce Page Protection: Don't show in perma private browsing mode r=emz
https://github.com/mozilla-firefox/firefox/commit/5d8f8323bbec
https://hg.mozilla.org/integration/autoland/rev/55d793bdc7b9
Reduce Page Protection: Test that infobar doesn't show up in permanent browsing r=emz

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f090752e7cba
https://hg.mozilla.org/integration/autoland/rev/a280da0e4235
Revert "Bug 2033441 - Reduce Page Protection: Test that infobar doesn't show up in permanent browsing r=emz" for causing bc failures @ modules/test/browser/browser.toml

Comment 6

[amarc]

Backed out for causing bc failures

• Backout link
• Push with failures
• Failure Log

Comment 7

[Manuel Bucher [:manuel]]

Updated patch per test failure

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f91b22fa5d65
https://hg.mozilla.org/integration/autoland/rev/a45b17776a58
Reduce Page Protection: Don't show in perma private browsing mode r=emz
https://github.com/mozilla-firefox/firefox/commit/fc7b23174106
https://hg.mozilla.org/integration/autoland/rev/393c37b5e35a
Reduce Page Protection: Test that infobar doesn't show up in permanent browsing r=emz

Comment 9

[Silaghi Andreea]

https://hg.mozilla.org/mozilla-central/rev/a45b17776a58
https://hg.mozilla.org/mozilla-central/rev/393c37b5e35a