2033961 - browser.tabs.groups.enabled should disable drag-n-drop

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser: Tab Groups, defect, P3)

Description

[EpicTux123]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:150.0) Gecko/20100101 Firefox/150.0

Steps to reproduce:

Firefox v150 added an option to disable "Drag tabs together to create tab groups". However, that option is still shown even with "browser.tabs.groups.enabled = false" in about:config. It should probably not be the case.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Firefox::Tabbed Browser' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Stephen Thompson [:sthompson]]

Good point, thanks! There is a way to make the drag-specific setting depend on the tab groups pref. This is already being used to manage things like the settings for smart tab groups, which also depends on tab groups being enabled. https://searchfox.org/firefox-main/rev/c34ebfaedf1a009f0bd13f1700e9b795a1b520c7/browser/components/preferences/main.js#1757-1791

Comment 3

[David Whitman-Kinghorn]

Hi, would it be possible to get assigned to this bug? Been out of software development for a few years, but trying to get back into it.

Comment 4

[Stephen Thompson [:sthompson]]

Sure. It's yours! Let me know if you have any questions.

Comment 5

[David Whitman-Kinghorn]

Thank you! I'll definitely ask if I'm having trouble.

Comment 6

[David Whitman-Kinghorn]

Can you unassign me from this ticket? I'm not going to have the time to work on it for a while. Sorry about that.

Comment 7

[Stephen Thompson [:sthompson]]

Will do. Take care!

Comment 8

[Jonathan Lau]

Hi, I would like to work on this. Could you assign it to me?

Comment 9

[Zyphrenn]

Attachment: Bug 2033961 - Hide "Drag tabs together to create tab groups" setting when tab groups are disabled. r=sthompson

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eae0e8b72b84
https://hg.mozilla.org/integration/autoland/rev/74b206f13f97
Hide "Drag tabs together to create tab groups" setting when tab groups are disabled. r=sthompson,akulyk

Comment 12

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/74b206f13f97