Closed Bug 2034400 Opened 2 months ago Closed 2 months ago

Access Connector feature icon is overlapped by VPN integration and matching domains are inactive

Categories

(Enterprise Products :: Firefox, defect)

defect

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: mcurtean, Assigned: jporter)

References

(Blocks 1 open bug, Regression)

Details

(Keywords: regression)

Attachments

(2 files)

Found in
enterprise-main build 152.0a1 (20260422165639)

Affected versions
enterprise-main build 152.0a1 (20260422165639)

Affected environment
Stage

Tested platforms
MacOS Tahoe 26,3

Preconditions
Admin access to Stage console .
Access Connector policy Applied in console

{
  "Host": "proxy.enterfox.eu",
  "MatchPatterns": [
    "https://*.mozilla.org",
    "https://mozilla.org",
    "http://enterprise-console-static.default.svc.cluster.local",
    "http://rustfs.rustfs-svc.svc.cluster.local"
  ],
  "Port": 443
}

Firefox is installed.

Steps to reproduce

  1. Log in on FxE using SSO and acess about:policies.
  2. Check that the policy is correctly applied.
  3. Check that the AccessConnector icon is available in the toolbar on both active (domains that match the policy) and inactive domains (all other domains)

Expected result
AccesConnector icon is available in the toolbar once the policy is active and it is generally inactive and active only on the domains matching the policy.

Actual result
AccessConnector policy is active in about:policies, but the VPN integration icon replaces the AccessConnector icon and the configured domains sappear as inactive.

QA Whiteboard: [Pilot][Pasteur][S1]
OS: Linux → All
Hardware: x86_64 → All

It looks like one need a new profile to make sure to repro.

So far I could narrow down to:

$ git log --oneline be9992a683b6f8536999c2c50a8fef5a9d158a5c..562062aa00d4b931c5dc083d49ed22a54644b9e5  browser/components/ipprotection/ toolkit/components/ipprotection/
562062aa00d4b Merge branch 'bookmarks/central' into enterprise-main
7003960076b5e Bug 2031544 — show site exclusion confirmation hint once per unique excluded site only. r=ip-protection-reviewers,rking
3baa4071fd2bd Bug 2023419 - Remove remaining Emacs/Vim modelines from the source tree r=emilio,necko-reviewers,geckoview-reviewers,media-playback-reviewers,webidl,webrtc-reviewers,devtools-reviewers,places-reviewers,win-reviewers,firefox-style-system-reviewers,layout-reviewers,mstriemer,dshin,nchevobbe,padenot,ohall,handyman,valentin,mjf
df88299c2affe Bug 2032605 - Add conditional attention dot to IP Protection toolbar button - r=ip-protection-reviewers,desktop-theme-reviewers,mhynson,dao
612466a164e5d Bug 2031971 - Implement an IP Protection Auth Provider to support the new guardian auth flow, r=sstreich,jonalmeida
0b36d0f917b2f Fix browser/components/ipprotection/IPProtectionPanel.sys.mjs from merge conflict
8b119b43d0981 Bug 2032173 - Dismiss infobar and in-panel warnings in all windows if dismissed in active window - r=ip-protection-reviewers,fchasen

On enterprise-main this repros properly with mach run and a local policies.json file (bypassing FELT). Locally reverting df88299c2affe seems to fix the issue, so it would be a regression from bug 2032605 (that will be uplifted to beta)

Keywords: regression
Regressed by: 2032605

(In reply to :gerard-majax from comment #1)

It looks like one need a new profile to make sure to repro.

So far I could narrow down to:

$ git log --oneline be9992a683b6f8536999c2c50a8fef5a9d158a5c..562062aa00d4b931c5dc083d49ed22a54644b9e5  browser/components/ipprotection/ toolkit/components/ipprotection/
562062aa00d4b Merge branch 'bookmarks/central' into enterprise-main
7003960076b5e Bug 2031544 — show site exclusion confirmation hint once per unique excluded site only. r=ip-protection-reviewers,rking
3baa4071fd2bd Bug 2023419 - Remove remaining Emacs/Vim modelines from the source tree r=emilio,necko-reviewers,geckoview-reviewers,media-playback-reviewers,webidl,webrtc-reviewers,devtools-reviewers,places-reviewers,win-reviewers,firefox-style-system-reviewers,layout-reviewers,mstriemer,dshin,nchevobbe,padenot,ohall,handyman,valentin,mjf
df88299c2affe Bug 2032605 - Add conditional attention dot to IP Protection toolbar button - r=ip-protection-reviewers,desktop-theme-reviewers,mhynson,dao
612466a164e5d Bug 2031971 - Implement an IP Protection Auth Provider to support the new guardian auth flow, r=sstreich,jonalmeida
0b36d0f917b2f Fix browser/components/ipprotection/IPProtectionPanel.sys.mjs from merge conflict
8b119b43d0981 Bug 2032173 - Dismiss infobar and in-panel warnings in all windows if dismissed in active window - r=ip-protection-reviewers,fchasen

On enterprise-main this repros properly with mach run and a local policies.json file (bypassing FELT). Locally reverting df88299c2affe seems to fix the issue, so it would be a regression from bug 2032605 (that will be uplifted to beta)

OK from that bug it adds a notification dot for some feature deployment warning related to VPN. Once one has clicked the icon with the dot, it seems the enforcement of the notification dot does not apply anymore and access connector is visible again.

OK it's not just broken from UI side, locally reverting that only change, the icon shows but the feature is still broken on first run on a fresh profile

Blocks: 2034487
Assignee: nobody → joporter

Authored by https://github.com/jporter-dev
https://github.com/mozilla/enterprise-firefox/commit/5dd67602a141e1ea2c99d340b67da5a4a7b46991
[enterprise-main] Bug 2034400 - Lock browser.ipProtection.openedPanelWithLocation with AccessConnector policy to prevent transient VPN button with dot from showing

Authored by https://github.com/lissyx
https://github.com/mozilla/enterprise-firefox/commit/f11482d9a1ade42cebae49fb8f12e1ed4991b91c
[enterprise-main] Merge pull request #784 from jporter-dev/enterprise-bug2034400-access-connector-feature-icon-overlapped-by-vpn

Status: NEW → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Flags: qe-verify+
Blocks: 2034821

Technically fixed on 152.0a1 20260424081038 as the the correct icon shows up an initially the domains are active, but the the icon randomly disappears and then active status also switches to inactive occasionally when restarting. Logged 2034821 for the new behavior.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: