2034484 - 'Cancel Message' functionality not working

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Hartmut Welpmann [:welpy-cw]]

STR:

1. Compose a newsgroup posting and send it to a test group.
2. Select the posting once it has appeared in the group and cancel the message via context menu.

Expected Result:
Confirmation dialog appears, message is canceled after confirming.

Actual Result:
Nothing happens, only the console logs

 Uncaught NS_ERROR_ILLEGAL_VALUE: Component returned failure code: 0x80070057 (NS_ERROR_ILLEGAL_VALUE) [nsIMsgNewsFolder.cancelMessage]
    cmd_cancel chrome://messenger/content/mailCommon.js:79
    doCommand chrome://messenger/content/mailCommon.js:722
    onMailContextMenuCommand chrome://messenger/content/mailContext.js:559
    onCommand chrome://messenger/content/mailContext.js:166
    handleEvent chrome://messenger/content/mailContext.js:148

There is no workaround.

Comment 1

[Hartmut Welpmann [:welpy-cw]]

Attachment: Bug 2034484 - Fix 'Cancel Message' regression. r=mkmelin

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/d63aab6d766b
Fix 'Cancel Message' regression. r=mkmelin

Comment 3

[Magnus Melin [:mkmelin]]

Please request 151 uplift

Comment 5

[Hartmut Welpmann [:welpy-cw]]

Comment on attachment 9572965 [details]
Bug 2034484 - Fix 'Cancel Message' regression. r=mkmelin

Uplift Approval Request

• Please state case for uplift consideration and ensure bug severity is set: Basic functionality fails without any workaround at all.
• User impact if declined: Canceling a newsgroup posting is not possible.
• Is this code covered by automated tests?: Unknown
• Has the fix been verified in Daily?: Yes
• Has the fix been verified in Beta?: No
• Needs manual test from QA?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Fix is as simple as it can be, just removing a faulty assertion.
• Does the fix cause any migrations to be skipped?: No
• String changes made/needed: None

Comment 6

[Corey Bryant]

Comment on attachment 9572965 [details]
Bug 2034484 - Fix 'Cancel Message' regression. r=mkmelin

[Triage Comment]
Approved for beta

Comment 7

[Corey Bryant]

Thunderbird 151.0b4:
https://hg-edge.mozilla.org/releases/comm-beta/rev/5f6fabc50666ea449252186184cea7526b6dc1b9

Comment 8

[Stephen King (:sking)]

Thunderbird 151.0b4:
https://hg.mozilla.org/releases/comm-beta/rev/5f6fabc50666