2035943 - Need a way to get both profiled and non-profiled sp3 runs with a single ./mach try command

Status: RESOLVED FIXED

(Testing :: Performance, enhancement, P2)

Description

[Markus Stange [:mstange]]

We want to make it easy for developers to find out "Does my patch impact performance, and if so, how?" using the tryserver. To answer these questions, developers need both performance numbers, and profiles:

• Before/after numbers so that PerfCompare can check if the actual score has changed, without any skew from profiling
• Before/after profiles so that they can see how exactly the runtime within a function has changed as a result of the patch

And with profiles I mean both Gecko profiler profiles and native profiler profiles (simpleperf / ETW).

There needs to be a single ./mach try command which triggers both kinds of jobs, so that it's fire and forget. What we don't want is "push, wait for some jobs to be ready, retrigger job with profiling, wait again" - there must only be one wait roundtrip.

I have no opinion on the exact command syntax.

Comment 1

[Greg Mierzwinski [:sparky]]

I met with Abhishek about this one, and he'll use the --native-profiling flag but with an argument to allow both tasks to get added. It'll default to only 1 (the profiling task) at the start since they'll be impacted by the --rebuild flag. That can change later once the feature in bug 2034253 gets implemented (per-task rebuild specifications).

Comment 2

[Abhishek Nimalan [:animalan]]

Attachment: WIP: Bug 2035943 - Allow --native-profiling to create an additional profiling task instead of modifying the original. r?#perftest

--native-profiling=both creates a new profiling task (suffixed with
-native-profiling) alongside the original task. This allows both the
original task and the profiling version to be run in the same ./mach try
command.

Comment 3

[Abhishek Nimalan [:animalan]]

Attachment: Bug 2035943 - Create an additional native profiling task instead of modifying the original. r?#perftest

Comment 4

[Abhishek Nimalan [:animalan]]

Per the recent talks, we will resolve this by removing the --native-profiling Try flag and creating duplicate jobs with native profiling.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/940c89f6b3c1
https://hg.mozilla.org/integration/autoland/rev/c4dcbf052735
Create an additional native profiling task instead of modifying the original. r=perftest-reviewers,sparky

Comment 6

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/c4dcbf052735