2036971 - Fix geckoview-junit test assertions that were bypassed on Kotlin <2.4

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Ryan VanderMeulen [:RyanVM]]

Three tests had incorrect @AssertCalled count/order constraints or wrong expected values that were silently bypassed on Kotlin 2.3 and older due to a Kotlin bridge-method annotation propagation issue. Discovered while diagnosing Kotlin 2.4 geckoview-junit failures.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2036971 - Match the resolved absolute URL in locationReplaceOnUserGesture. r=#geckoview-reviewers

The onLocationChange callback receives the absolute URL (Services.io's
displaySpec for the resolved URI), not the relative argument passed to
window.location.replace(). The strict equalTo check only avoided
failing because the bridge-method @AssertCalled propagation suppressed
this override on Kotlin 2.3.21 — the assertion was never evaluated.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2036971 - Fix expected delegate-call order in openWindowNewClosedSession. r=#geckoview-reviewers

The actual delivery order is onLocationChange(about:blank) ->
onLoadRequest(target) -> onLocationChange(target) -> onTitleChange.
The hard-coded [1,2,3,4] order was wrong (it placed onLoadRequest
after the two location changes); update to [1,3] / [2] / [4].

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2036971 - Click the notification action button in openWindowWithActionAfterAlertServiceTeardown. r=#geckoview-reviewers

WebNotification.click() simulates a notification-body click and produces
a notificationclick event with event.action = "". The service-worker
fixture only appends ?action=<id> to the target URL when event.action
is non-empty, so the test's expected URL (with ?action=foo) was never
attainable through click(). Use the click(action) overload to simulate
clicking the action button instead.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/7a23994f19c1
https://hg.mozilla.org/integration/autoland/rev/a974ea9baaec
Match the resolved absolute URL in locationReplaceOnUserGesture. r=geckoview-reviewers,ohall
https://github.com/mozilla-firefox/firefox/commit/c2751649914d
https://hg.mozilla.org/integration/autoland/rev/121de9b402bc
Fix expected delegate-call order in openWindowNewClosedSession. r=geckoview-reviewers,ohall
https://github.com/mozilla-firefox/firefox/commit/5d4df13e5f9b
https://hg.mozilla.org/integration/autoland/rev/a3ed62235aaa
Click the notification action button in openWindowWithActionAfterAlertServiceTeardown. r=geckoview-reviewers,ohall

Comment 5

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a974ea9baaec
https://hg.mozilla.org/mozilla-central/rev/121de9b402bc
https://hg.mozilla.org/mozilla-central/rev/a3ed62235aaa