2035985 - Update Kotlin to version 2.4.0

Status: RESOLVED FIXED

(Firefox for Android :: Tooling, task)

Description

[Ryan VanderMeulen [:RyanVM]]

Currently in Beta, but there's bugs we can fix now in preparation for it.

Comment 1

[Ryan VanderMeulen [:RyanVM]]

Turns out this is going to be blocked on updating to AGP 9 due to UAST changes that break some pretty common lint checks, so that's not fun.
https://youtrack.jetbrains.com/issue/KT-86080

Comment 2

[Ryan VanderMeulen [:RyanVM]]

https://github.com/JetBrains/kotlin/releases/tag/v2.4.0

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Green on Try: https://treeherder.mozilla.org/jobs?repo=try&revision=dad5a1246b19f37a402a17acae40f677a344484b

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2035985 - Update Kotlin to version 2.4.0 r?#android-reviewers

Also bump semanticdb-kotlinc to 0.10.0, the first release compatible with
Kotlin 2.4, so the scip-kotlin indexing plugin can stay enabled.

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Attachment: Bug 2035985 - Suppress UNSAFE_CAST_RELYING_ON_NULL warning in generated SafeArgs code r?#android-reviewers

Kotlin 2.4 renamed the warning emitted by the generated androidx.navigation
SafeArgs code from USELESS_CAST to UNSAFE_CAST_RELYING_ON_NULL, so update the
existing generated-code suppression to match. The underlying issue is still
open upstream: https://issuetracker.google.com/issues/458082829

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/be0b36393000
https://hg.mozilla.org/integration/autoland/rev/f00f4354b65d
Update Kotlin to version 2.4.0 r=android-reviewers,mcarare
https://github.com/mozilla-firefox/firefox/commit/cf72989cc52c
https://hg.mozilla.org/integration/autoland/rev/c164f38113ca
Suppress UNSAFE_CAST_RELYING_ON_NULL warning in generated SafeArgs code r=android-reviewers,mcarare

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/f00f4354b65d
https://hg.mozilla.org/mozilla-central/rev/c164f38113ca