Closed Bug 2037056 Opened 1 month ago Closed 28 days ago

Extra large VPN Status Checkbox in Overflow Menu

Categories

(Firefox :: IP Protection, defect)

Firefox 151
Desktop
macOS
defect

Tracking

()

VERIFIED FIXED
153 Branch
Tracking Status
firefox151 --- wontfix
firefox152 --- verified
firefox153 --- verified

People

(Reporter: vvalentina, Assigned: mhynson)

References

(Blocks 2 open bugs)

Details

(Whiteboard: [fx-vpn])

Attachments

(5 files, 2 obsolete files)

Prerequisites

  • Browser: Firefox Nightly 152.0a1
  • Operating System: macOS 26, Windows 11
  • Configuration: Built-inVPN built-in feature added to the toolbar

Steps to Reproduce

  1. Open Firefox Nightly 152.0a1 in a clean profile.
  2. Click the VPN toolbar icon;
  3. Click the location button;
  4. While having the locations list open right-click the VPN toolbar icon and select "Move to Overflow Menu" (or customize the toolbar to drag it into the overflow area).
  5. Click the chevron (>>) icon to open the Overflow Menu.
  6. Observe the visual representation of the VPN status toggle/checkbox within the menu list.

Expected Results
The VPN status checkbox/toggle should be proportionally scaled.

Actual Results
The VPN status checkbox appears abnormally large.

Notes

Summary: Large VPN Status Checkbox is added in Overflow Menu while location list is opened → Extra large VPN Status Checkbox in Overflow Menu
Assignee: nobody → mhynson
Status: NEW → ASSIGNED
Pushed by mhynson@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/9b4cfc5b3f89 https://hg.mozilla.org/integration/autoland/rev/1d50e42720aa Fix extra large VPN Status Checkbox in Overflow Menu. r=ip-protection-reviewers,desktop-theme-reviewers,dao,kpatenio
Status: ASSIGNED → RESOLVED
Closed: 1 month ago
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch

The patch landed in nightly and beta is affected.
:mhynson, is this bug important enough to require an uplift?

For more information, please visit BugBot documentation.

Flags: needinfo?(mhynson)

To add to Comment 4, it's too late for Fx151 beta. We could review a release uplift request for inclusion in a Fx151 dot release.

Thank you for the update. Uplift requested for a Fx151 dot release

Flags: needinfo?(mhynson)

The uplift request had conflicts with release

Flags: needinfo?(mhynson)
Attachment #9586416 - Flags: approval-mozilla-release?

firefox-release Uplift Approval Request

  • User impact if declined/Reason for urgency: Fixes a UI/UX bug for the overflow menu
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: - Enable VPN
  • Right-click the VPN toolbar icon and select "Pin to Overflow Menu"
  • Click the chevron (>>) icon to open the Overflow Menu.
  • Verify that the icon size is properly sized (16px)
  • Risk associated with taking this patch: low
  • Explanation of risk level: Potentially affects a limited amount of users
  • String changes made/needed?: None
  • Is Android affected?: no
Flags: qe-verify+

Conflicts resolved

Flags: needinfo?(mhynson)
QA Whiteboard: [qa-triage-done-c152/b151]
QA Contact: vvirlics
Attached image large

Verified this while using Firefox Nightly 153.0a1 (18-05-2026) on macOS 26.
The VPN icon is still too large, but you need to turn VPN ON and switch between locations to reproduce it intermitently. Further more, seems that it gets worse after browser restart.
Attaching ss.
Should we reopen this or log another issue?

Flags: needinfo?(mhynson)

Thank you for verifying. This can be reopened.

Flags: needinfo?(mhynson)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by mhynson@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/89ae2939b8f4 https://hg.mozilla.org/integration/autoland/rev/2a2f9694be0e Fix extra large VPN Icon in Overflow Menu. r=ip-protection-reviewers,desktop-theme-reviewers,dao,rking
Target Milestone: 152 Branch → ---
Status: REOPENED → RESOLVED
Closed: 1 month ago28 days ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Attachment #9588498 - Flags: approval-mozilla-release?

firefox-release Uplift Approval Request

  • User impact if declined/Reason for urgency: Fixes a UI/UX bug for the overflow menu
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: yes
  • Steps to reproduce for manual QE testing: - Enable VPN
  • Right-click the VPN toolbar icon and select "Pin to Overflow Menu"
  • Click the chevron (>>) icon to open the Overflow Menu.
  • Verify that the icon size is properly sized (16px)
  • Risk associated with taking this patch: low
  • Explanation of risk level: Potentially affects a limited amount of users
  • String changes made/needed?: None
  • Is Android affected?: no

Michael, the second patch that landed in Fx153 firefox-main also needs a beta uplift request to make Fx142 beta
https://lando.moz.tools/D301317/

Flags: needinfo?(mhynson)

firefox-beta Uplift Approval Request

  • User impact if declined/Reason for urgency: Fixes a UI/UX bug for the overflow menu
  • Code covered by automated testing?: no
  • Fix verified in Nightly?: yes
  • Needs manual QE testing?: no
  • Steps to reproduce for manual QE testing: - Enable VPN
  • Right-click the VPN toolbar icon and select "Pin to Overflow Menu"
  • Click the chevron (>>) icon to open the Overflow Menu.
  • Verify that the icon size is properly sized (16px)
  • Risk associated with taking this patch: low
  • Explanation of risk level: Potentially affects a limited amount of users
  • String changes made/needed?: None
  • Is Android affected?: no
Attachment #9588685 - Flags: approval-mozilla-beta?
Attachment #9588685 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Flags: needinfo?(mhynson)
Attachment #9588498 - Flags: approval-mozilla-release? → approval-mozilla-release+
Attachment #9586416 - Flags: approval-mozilla-release? → approval-mozilla-release+
Regressions: 2037872
Regressions: 2042454

Verified this while using Firefox Nightly 153.0a1 (27-05-2026), Firefox Beta 152.0b3 and Firefox release 151.0.2 on macOS 26.
The VPN icon is small after being added to Overflow menu. Switch between locations does not reproduce it. Browser restart does not trigger it either.

Status: RESOLVED → VERIFIED
Flags: qe-verify+

Backed out of release due to Bug 2042454

Whiteboard: [fx-vpn]
Attachment #9586416 - Attachment is obsolete: true
Attachment #9588498 - Attachment is obsolete: true
Blocks: 2042992

Verified this while using Firefox Release candidate 151.0.3 on Windows 11/macOS 26.
The fix for this was backed-out and the VPN icon is enlarged after being added to Overflow menu.

You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: