2037133 - DNS over HTTPS settings incorrectly shows an error

Status: VERIFIED FIXED

(Firefox :: Settings UI, defect, P2)

Description

[Valentin Gosu [:valentin]]

Attachment: image.png

This is in mode3, and using Cloudflare.
DNS works, but the status is shown as failing (TRR_OK)

152.0a1 (2026-05-04)

I also see this in the console, so the error might not be in the DoH parts, but caused by this error in the initialization of the preferences:

Uncaught (in promise) TypeError: can't access property "replace", record['cc-exp'] is undefined
    items resource://autofill/FormAutofillPreferences.sys.mjs:268
    makePaymentsListItems resource://autofill/FormAutofillPreferences.sys.mjs:260
FormAutofillPreferences.sys.mjs:268:15
Error: preference with id 'browser.newtabpage.activity-stream.showSearch' already added Preferences.mjs:48:13
    _add chrome://global/content/preferences/Preferences.mjs:48
    addAll chrome://global/content/preferences/Preferences.mjs:73
    map self-hosted:163
    addAll chrome://global/content/preferences/Preferences.mjs:73
    _registerPreferences resource://newtab/lib/AboutPreferences.sys.mjs:200
    observe resource://newtab/lib/AboutPreferences.sys.mjs:167
    init chrome://browser/content/preferences/widgets/setting-pane.mjs:149
    init chrome://browser/content/preferences/config/SettingPaneManager.mjs:97
    init chrome://browser/content/preferences/preferences.js:427
    initializeCategories chrome://browser/content/preferences/findInPage.js:118
    init chrome://browser/content/preferences/findInPage.js:78

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1971428

:bvandersloot, since you are the author of the regressor, bug 1971428, could you take a look? Also, could you set the severity field?

For more information, please visit BugBot documentation.

Comment 2

[Valentin Gosu [:valentin]]

I think this may actually be caused by the pref being set both here and here

Comment 3

[Benjamin VanderSloot [:bvandersloot]]

Those probably aren't those callsites, but since you have browser.newtabpage.activity-stream.showSearch getting added twice erroring in your console, I would think that is it.

Bug 2031707 looks like the last place it was added, so I'll add that as a candidate regressor.

Comment 4

[Hanna Jones [:hjones]]

We have a related bug 2037143 filed over in the Home and New Tab component, we should fix this before we ship.

Comment 5

[Stuart Colville [:muffinresearch]]

I tried reverting the fix in bug 2033049 locally and it doesn't seem to stop the DoH errors, so I don't think this is the underlying cause. :bvandersloot do you have other ideas of what the cause might be?

Comment 6

[Benjamin VanderSloot [:bvandersloot]]

Answer after some better investigation and debuger statements... it was a few missed variable renames during the panel migration lint cleanup. Patch incoming.

Comment 7

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 2037133 - Fix DNS over HTTPS settings incorrectly shows an error - r=valentin!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/279e037224ec
https://hg.mozilla.org/integration/autoland/rev/bf698b531f03
Fix DNS over HTTPS settings incorrectly shows an error - r=valentin,hjones

Comment 9

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/bf698b531f03

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:bvandersloot, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
  • See https://wiki.mozilla.org/Release_Management/Requesting_an_Uplift for documentation on how to request an uplift.
• If no, please set status-firefox151 to wontfix.

For more information, please visit BugBot documentation.

Comment 11

[Negritas Sergiu, Desktop QA]

Hello I can confirm that the issue is fixed with firefox 152.0b1 and 153.0a1(2026-05-19) on Ubuntu 24.04, Windows 10 and macOS 15.6.7