1971428 - Convert DoH to config-based prefs

Status: RESOLVED FIXED

(Firefox :: Settings UI, task)

Description

[Mark Striemer [:mstriemer]]

The DoH section on the Privacy & Security settings page should be converted to the config-based settings system. Note that the Increased/Max protection options have been combined into "Custom" with a checkbox to allow falling back to regular DNS.

These changes can be made in the existing Privacy & Security page. The end result should be the following settings:

• Message bar of current status
• DoH Setting radio group:
  • Default
  • Custom
    • Allow fallback to default DNS checkbox
    • Provider select
  • Off
• Manage exceptions button (opens the existing modal)

Comment 1

[Benjamin VanderSloot [:bvandersloot]]

Attachment: Bug 1971428 - Convert DoH to config-based prefs - r=valentin!,#recomp-reviewers!

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/483d918796d7
https://hg.mozilla.org/integration/autoland/rev/46369f902551
Convert DoH to config-based prefs - r=valentin,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/d738f8c352cc
https://hg.mozilla.org/integration/autoland/rev/ee212f6302e7
Revert "Bug 1971428, Bug 1972371 - Convert DoH to config-based prefs - r=valentin,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson" for causing chrome failures on test_moz_message_bar.html

Comment 4

[Cristina Horotan [:chorotan]]

Backed out for causing chrome failures on test_moz_message_bar.html

Backout link

Push with failures

Failure log
Failure log bc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/f477664870bf
https://hg.mozilla.org/integration/autoland/rev/353a01828040
Convert DoH to config-based prefs - r=valentin,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/72a6633a4bc7
https://hg.mozilla.org/integration/autoland/rev/8831b5ffb5eb
Revert "Bug 1971428 - Convert DoH to config-based prefs - r=valentin,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson" for causing bc failures @ browser_search_within_preferences_1.js

Comment 7

[Sandor Molnar[:smolnar]]

Backed out for causing bc failures @ browser_search_within_preferences_1.js

Backout link: https://hg.mozilla.org/integration/autoland/rev/8831b5ffb5eb2b20047eba74e46010bba9f84b62

Push with failures

Failure log -> TEST-UNEXPECTED-FAIL | browser/components/preferences/tests/browser_search_within_preferences_1.js

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/779e85fffe11
https://hg.mozilla.org/integration/autoland/rev/c6c8088fa749
Convert DoH to config-based prefs - r=valentin,fluent-reviewers,desktop-theme-reviewers,hjones,bolsson

Comment 9

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/c6c8088fa749