203734 - OS X: xul buttons no longer display focus in aqua/classic theme

Status: VERIFIED FIXED

(Core Graveyard :: GFX: Mac, defect, P2)

Description

[sairuh (rarely reading bugmail)]

buttons in XUL (pref panels, account wizard, etc) no longer display the focus
ring when they are in focus. they still activate, however.

this regressed btwn 2003.04.04.09 (works fine) and 2003.04.09.10 (broken) builds.

0. make sure you're using the aqua/classic theme.
1. open up a sheet or window that has a xul button, eg, Navigator pref panel,
account setup wizard, etc.
2. hit the tab key to move focus.

results: the focus ring is displayed for textfields (caret, really), checkboxes
and radiobuttons. when focus is on a button, no focus ring is displayed.

Comment 1

[Greg K.]

Wasn't this done deliberately in bug 197094 to fix bug 162877?

Comment 2

[sairuh (rarely reading bugmail)]

hmmm...brian?

Comment 3

[Samir Gehani]

adt: nsbeta1-

Comment 4

[Marco De Vitis]

Still confirmed in Mozilla 1.7rc2 on Mac OS X 10.3.4 with default theme.
This is a serious accessibility problem IMHO, can something be done about it?

Comment 5

[Hiro]

bug74058 and bug175279 may depend.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Too late for 1.8b1, but this seems like it may be something that should block 1.8b2.

Comment 7

[Asaf Romano (gone)]

Note to self: Need to check if push buttons' focus ring (from HITheme/Appearance
Manager) is less buggy in Tiger.

Comment 8

[Asaf Romano (gone)]

OK, that OS bug is fixed on 10.4

Comment 9

[Asaf Romano (gone)]

Attachment: enable push buttons focus ring on 10.4 and above

Comment 10

[Simon Fraser [no longer active]]

Comment on attachment 185143 [details] [diff] [review]
enable push buttons focus ring on 10.4 and above

> PRBool
>-nsRenderingContextMac::OnJaguar()
>+nsRenderingContextMac::OnJaguarOrLater()
> {
>   static PRBool sInitVer = PR_FALSE;
>-  static PRBool sOnJaguar = PR_FALSE;
>+  static PRBool sOnJaguarOrLater = PR_FALSE;
>   if (!sInitVer) {
>     long version;
>     OSErr err = ::Gestalt(gestaltSystemVersion, &version);
>-    sOnJaguar = (err == noErr && version >= 0x00001020);
>+    sOnJaguarOrLater = (err == noErr && version >= 0x00001020);

I'd prefer braces here to make the precedence clearer:

      sOnJaguarOrLater = ((err == noErr) && (version >= 0x00001020));

>+
>+PRBool
>+nsRenderingContextMac::OnTigerOrLater()
>+{
>+  static PRBool sInitVer = PR_FALSE;
>+  static PRBool sOnTigerOrLater = PR_FALSE;
>+  if (!sInitVer) {
>+    long version;
>+    OSErr err = ::Gestalt(gestaltSystemVersion, &version);
>+    sOnTigerOrLater = (err == noErr && version >= 0x00001040);

Ditto.

Comment 11

[sairuh (rarely reading bugmail)]

(In reply to comment #8)
> OK, that OS bug is fixed on 10.4

since this will remain an issue on OS X 10.3 and earlier, this should be
relnoted for those earlier OS's. also see bug 242831 comment 23.

Comment 12

[jhp (no longer active)]

Comment on attachment 185143 [details] [diff] [review]
enable push buttons focus ring on 10.4 and above

Looks good.  But I couldn't find any place to test this on the trunk; none of
the buttons seem to be focusable in any of the XUL dialogs.

Comment 13

[Asaf Romano (gone)]

see bug 242831 for that bit.

Comment 14

[Asaf Romano (gone)]

Checking in nsImageMac.cpp;
/cvsroot/mozilla/gfx/src/mac/nsImageMac.cpp,v  <--  nsImageMac.cpp
new revision: 1.78; previous revision: 1.77
done
Checking in nsNativeThemeMac.cpp;
/cvsroot/mozilla/gfx/src/mac/nsNativeThemeMac.cpp,v  <--  nsNativeThemeMac.cpp
new revision: 1.39; previous revision: 1.38
done
Checking in nsRenderingContextMac.cpp;
/cvsroot/mozilla/gfx/src/mac/nsRenderingContextMac.cpp,v  <-- 
nsRenderingContextMac.cpp
new revision: 1.164; previous revision: 1.163
done
Checking in nsRenderingContextMac.h;
/cvsroot/mozilla/gfx/src/mac/nsRenderingContextMac.h,v  <--  nsRenderingContextMac.h
new 

Comment 15

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2005060807-trunk deer park build on OS X 10.4.1. thanks for
fixing this, Mano!