Closed
Bug 2037654
Opened 6 months ago
Closed 6 months ago
Prepare ETP tests for the SRD pref flip
Categories
(Firefox :: Settings UI, task)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
153 Branch
People
(Reporter: hjones, Assigned: hjones)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp])
Attachments
(2 external files)
We need to make sure our tests for ETP features in preferences will pass with the SRD pref enabled or disabled. We need to:
- create a new
browser-srd.tomlfile for sync tests that duplicates the old/browser/components/preferences/tests/etp/browser.toml, but withdupe-manifest=trueand thebrowser.settings-redesign.enabledpref set totrue - register this manifest in
browser/components/preferences/moz.build - remove any tests that already set
browser.settings-redesign.enabledtotruefrom the oldbrowser.tomlfile since these don't need to work with the pref disabled - clean up any code setting the SRD pref from within the test files (this will be read from the manifest)
- remove any tests from the new manifest that are only relevant to the old UI
- fix any failing tests
- add new tests if there are any obvious gaps
Updated•6 months ago
|
| Assignee | ||
Updated•6 months ago
|
| Assignee | ||
Updated•6 months ago
|
Assignee: nobody → hjones
| Assignee | ||
Comment 1•6 months ago
|
||
Pushed by hjones@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/cc33fbe4a5a7
https://hg.mozilla.org/integration/autoland/rev/09ba373592e1
Prepare ETP tests for the SRD pref flip r=akulyk
Comment 3•6 months ago
|
||
Backed out for causing failures at browser_startup_browser_restore_session.js.
Backout link: https://hg.mozilla.org/integration/autoland/rev/ede508751f60
Failure log: https://treeherder.mozilla.org/logviewer?job_id=567499397&repo=autoland&task=DMpksoWzRziT1xAo4FDpXg.0&lineNumber=9002
Comment 4•6 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Updated•6 months ago
|
Status: RESOLVED → REOPENED
status-firefox153:
fixed → ---
Resolution: FIXED → ---
Target Milestone: 153 Branch → ---
| Assignee | ||
Comment 5•6 months ago
|
||
Original Revision: https://phabricator.services.mozilla.com/D300479
Updated•6 months ago
|
Attachment #9588036 -
Flags: approval-mozilla-beta?
Status: REOPENED → RESOLVED
Closed: 6 months ago → 6 months ago
status-firefox153:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Updated•6 months ago
|
Flags: in-testsuite+
Updated•6 months ago
|
Attachment #9588036 -
Flags: approval-mozilla-beta? → approval-mozilla-beta+
Updated•6 months ago
|
status-firefox152:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•