Closed Bug 2037654 Opened 6 months ago Closed 6 months ago

Prepare ETP tests for the SRD pref flip

Categories

(Firefox :: Settings UI, task)

task

Tracking

()

RESOLVED FIXED
153 Branch
Tracking Status
firefox152 --- fixed
firefox153 --- fixed

People

(Reporter: hjones, Assigned: hjones)

References

(Blocks 1 open bug)

Details

(Whiteboard: [recomp])

Attachments

(2 external files)

We need to make sure our tests for ETP features in preferences will pass with the SRD pref enabled or disabled. We need to:

  • create a new browser-srd.toml file for sync tests that duplicates the old /browser/components/preferences/tests/etp/browser.toml , but with dupe-manifest=true and the browser.settings-redesign.enabled pref set to true
  • register this manifest in browser/components/preferences/moz.build
  • remove any tests that already set browser.settings-redesign.enabled to true from the old browser.toml file since these don't need to work with the pref disabled
  • clean up any code setting the SRD pref from within the test files (this will be read from the manifest)
  • remove any tests from the new manifest that are only relevant to the old UI
  • fix any failing tests
  • add new tests if there are any obvious gaps
Blocks: 2037655
No longer blocks: 2037655
Blocks: 2037820
No longer blocks: srd-tests
Assignee: nobody → hjones
Regressions: 2040840
Regressions: 2040841
Regressions: 2040842
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Target Milestone: 153 Branch → ---
Attachment #9588036 - Flags: approval-mozilla-beta?
Status: REOPENED → RESOLVED
Closed: 6 months ago → 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 153 Branch
Flags: in-testsuite+
Attachment #9588036 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: