Closed
Bug 2037655
Opened 6 months ago
Closed 6 months ago
Prepare experimental features tests for the SRD pref flip
Categories
(Firefox :: Settings UI, task)
Firefox
Settings UI
Tracking
()
RESOLVED
FIXED
152 Branch
| Tracking | Status | |
|---|---|---|
| firefox152 | --- | fixed |
People
(Reporter: hjones, Assigned: mkennedy)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp])
Attachments
(1 external file)
We need to make sure our tests for experimental features in preferences will pass with the SRD pref enabled or disabled. We need to:
- create a new
browser-srd.tomlfile for sync tests that duplicates the old/browser/components/preferences/tests/experimental_features/browser.toml, but withdupe-manifest=trueand thebrowser.settings-redesign.enabledpref set totrue - register this manifest in
browser/components/preferences/moz.build - remove any tests that already set
browser.settings-redesign.enabledtotruefrom the oldbrowser.tomlfile since these don't need to work with the pref disabled - clean up any code setting the SRD pref from within the test files (this will be read from the manifest)
- remove any tests from the new manifest that are only relevant to the old UI
- fix any failing tests
- add new tests if there are any obvious gaps
Updated•6 months ago
|
| Reporter | ||
Updated•6 months ago
|
| Assignee | ||
Updated•6 months ago
|
Assignee: nobody → mkennedy
| Assignee | ||
Comment 1•6 months ago
|
||
Pushed by mkennedy@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/3944be945258
https://hg.mozilla.org/integration/autoland/rev/7303ce3ab700
Prepare experimental tests for the SRD pref flip r=tgiles
Pushed by imoraru@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/41980fd21dfe
https://hg.mozilla.org/integration/autoland/rev/e8a5b399e249
Revert "Bug 2037655 - Prepare experimental tests for the SRD pref flip r=tgiles" for causing bc failures on browser_experimental_features_hidden_when_not_public.js.
Comment 4•6 months ago
|
||
Revert for causing bc failures on browser_experimental_features_hidden_when_not_public.js.
Flags: needinfo?(mkennedy)
Pushed by mkennedy@mozilla.com:
https://github.com/mozilla-firefox/firefox/commit/9137a204a084
https://hg.mozilla.org/integration/autoland/rev/bca88343faf4
Prepare experimental tests for the SRD pref flip r=tgiles
| Assignee | ||
Updated•6 months ago
|
Flags: needinfo?(mkennedy)
Comment 6•6 months ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 6 months ago
status-firefox152:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 152 Branch
Updated•6 months ago
|
QA Whiteboard: [qa-triage-done-c153/b152]
You need to log in
before you can comment on or make changes to this bug.
Description
•